Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRI-321] Better handle errors bubbling up in subtasks #159

Closed
ericallam opened this issue Jul 13, 2023 · 12 comments
Closed

[TRI-321] Better handle errors bubbling up in subtasks #159

ericallam opened this issue Jul 13, 2023 · 12 comments
Assignees
Labels
Milestone

Comments

@ericallam
Copy link
Member

ericallam commented Jul 13, 2023

Currently when viewing a failed task because a subtasks threw an error is not a great experience. We need to improve that

When a subtask fails (and all retries are done) the error doesn't bubble up to the parent task. Instead you get a very generic: "Error: Task errored at IO.runTask".

Instead, a failed subtask should bubble that error up to parent tasks (so the subtask error is duplicated onto the parent).

You can easily reproduce this by creating a task with subtask inside that throws a specific error.

From SyncLinear.com | TRI-321

@ericallam ericallam self-assigned this Jul 13, 2023
@ericallam ericallam added the Urgent Created by Linear-GitHub Sync label Jul 13, 2023
@ericallam
Copy link
Member Author

/bounty $50

@algora-pbc
Copy link

algora-pbc bot commented Jul 14, 2023

💎 $50 bounty created by ericallam
🙋 If you'd like to work on this issue, comment below to get assigned
👉 To claim this bounty, submit a pull request that includes the text /claim #159 somewhere in its body
📝 Before proceeding, please make sure you can receive payouts in your country
💵 Payment arrives in your account 2-5 days after the bounty is rewarded
💯 You keep 100% of the bounty award
🙏 Thank you for contributing to triggerdotdev/trigger.dev!

@ericallam ericallam added High priority Created by Linear-GitHub Sync and removed Urgent Created by Linear-GitHub Sync labels Jul 14, 2023
@SSHari
Copy link
Contributor

SSHari commented Jul 17, 2023

@ericallam would it be possible to get more information about what the bad experience is and what the expected experience should be?

@tonie-ng
Copy link

/attempt #159

@rishi-raj-jain
Copy link
Contributor

@matt-aitken @ericallam

Would it be possible to get more information about what the bad experience is and what the expected experience should be?

@matt-aitken
Copy link
Member

I've added more information to the original issue

@matt-aitken
Copy link
Member

@RamK777-stack would you like to claim the Algora bounty?

@RamK777-stack
Copy link
Contributor

Yes @matt-aitken

@RamK777-stack
Copy link
Contributor

claim #159

@algora-pbc
Copy link

algora-pbc bot commented Sep 13, 2023

💡 @RamK777-stack submitted a pull request that claims the bounty. You can visit your org dashboard to reward.

@algora-pbc
Copy link

algora-pbc bot commented Sep 13, 2023

🎉🎈 @RamK777-stack has been awarded $50! 🎈🎊

@matt-aitken
Copy link
Member

This was fixed

@ericallam ericallam added this to the v.15 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants