fix: Added retry config and showed error from subtask in web #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: aed1f58 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matt-aitken
approved these changes
Sep 12, 2023
Member
matt-aitken
left a comment
matt-aitken
left a comment
There was a problem hiding this comment.
This is great! I made it so it falls back to "Task errored" if the task has no output
packages/trigger-sdk/src/io.ts
Outdated
| }); | ||
|
|
||
| throw new Error(task.error ?? "Task errored"); | ||
| throw new Error(task.error ?? JSON.stringify(task?.output)); |
Member
There was a problem hiding this comment.
I think we still need the fallback "Task errored", if there's no task.output.
Suggested change
| throw new Error(task.error ?? JSON.stringify(task?.output)); | |
| throw new Error(task.error ?? task?.output ? JSON.stringify(task.output) : "Task errored"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #422 and #159
/claim #159
Currently we are not showing the exact error on trigger.dev web If openAPI request failed. So I am trying to show the exact error and reason for the task failed.
My request failed because of insufficient quota, status code is 429. Unfortunately, both too many requests and insufficient quota are having same status code 429. This is with the background functions.
Previously it was
Now I have fixed this like this
Note: I didn't test positive flow. because currently, I don't have an active openAI key. I consumed all of my free quota