Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MueLu: improve factory unit testing #9743

Open
2 of 57 tasks
jhux2 opened this issue Sep 24, 2021 · 8 comments
Open
2 of 57 tasks

MueLu: improve factory unit testing #9743

jhux2 opened this issue Sep 24, 2021 · 8 comments
Labels
DO_NOT_AUTOCLOSE This issue should be exempt from auto-closing by the GitHub Actions bot. pkg: MueLu type: enhancement Issue is an enhancement, not a bug

Comments

@jhux2
Copy link
Member

jhux2 commented Sep 24, 2021

Enhancement

@trilinos/Muelu @csiefer2

This is a checklist of MueLu classes identified as having less than 75% code coverage (per analysis by @JacobDomagala on 2021-Sept-09).

The purpose of this checklist is guide the work of improving unit testing being done by NexGen Analytics.

Higher priority factories are bolded.

MueLu developers: If you see classes that you think should be prioritized, please bold them in the check list below.

muelu/adapters/stratimikos

  • Thyra_MueLuPreconditionerFactory
  • Thyra_XpetraLinearOp

muelu/adapters/tpetra

  • MueLu_TpetraOperator

muelu/adapters/xpetra

  • MueLu_Maxwell_Utils
  • MueLu_RefMaxwell
  • MueLu_Maxwell1

muelu/src/Graph/Containers

  • MueLu_LWGraph_kokkos_def
  • MueLu_LWGraph
  • MueLu_Zoltan2GraphAdapter

muelu/src/Graph/HybridAggregation

  • MueLu_HybridAggregationFactory (*must enable MueLu research code)

muelu/src/Graph/MatrixTransformation

  • MueLu_VariableDofLaplacianFactory
  • Muelu_AmalgamationInfo
  • MueLu_CoalesceDropFactory

muelu/src/Graph/StructuredAggregation

  • MueLu_IndexManager

muelu/src/Graph/StructuredAggregation/coupled

  • MueLu_GlobalLexicographicIndexManager

muelu/src/Graph/StructuredAggregation/uncoupled

  • MueLu_UncoupledIndexManager

muelu/src/Graph/UncoupledAggregation

  • MueLu_UncoupledAggregationFactory_kokkos
  • MueLu_UncoupledAggregationFactory
  • MueLu_PreserveDirichletAggregationAlgorithm_kokkos
  • MueLu_AggregationPhase3Algorithm

muelu/src/Graph/UserAggregation

  • MueLu_UserAggregationFactory

muelu/src/Interface

  • MueLu_AdaptiveSaMLParameterListInterpreter
  • MueLu_HierarchyManager
  • MueLu_ML2MueLuParameterTranslator

muelu/src/Interface/FacadeClasses

  • MueLu_Facade_Simple
  • MueLu_Facade_BGS2x2
  • MueLu_FacadeClassFactory
  • MueLu_FacadeClassBase

muelu/src/Misc

  • MueLu_FilteredAFactory
  • MueLu_SegregatedAFactory
  • MueLu_DropNegativeEntriesFactory
  • MueLu_CoordinatesTransferFactory_kokkos
  • MueLu_FineLevelInputDataFactory
  • MueLu_BlockedRAPFactory
  • MueLu_AggregateQualityEstimateFactory
  • MueLu_LineDetectionFactory

muelu/src/MueCentral

  • MueLu_FactoryManager

muelu/src/Rebalancing

  • MueLu_NodePartitionInterface
  • MueLu_RebalanceMapFactory
  • MueLu_RebalanceAcFactory
  • MueLu_RebalanceBlockInterpolationFactory

muelu/src/Smoothers

  • MueLu_NodePartitionInterface
  • MueLu_RebalanceMapFactory
  • MueLu_RebalanceAcFactory
  • MueLu_RebalanceAcFactory
  • MueLu_RebalanceBlockInterpolationFactory

muelu/src/Smoothers/BlockedSmoothers

  • MueLu_BlockedDirectSolver

muelu/src/Transfers/Classical

  • MueLu_ClassicalMapFactory_def.hpp

muelu/src/Transfers/Energy-Minimization

  • MueLu_EminPFactory_def.hpp

Transfers/Petrov-Galerkin-SA

  • MueLu_PGPFactory

muelu/src/Transfers/GeneralGeometric

  • MueLu_GeometricInterpolationPFactory_kokkos

muelu/src/Transfers/SemiCoarsen

  • MueLu_ToggleCoordinatesTransferFactory

muelu/src/Transfers/SmoothedAggregation

  • MueLu_SaPFactory
  • MueLu_SaPFactory_kokkos
  • MueLu_TentativePFactory
  • MueLu_TentativePFactory_kokkos

Transfers/User

  • MueLu_UserPFactory
@jhux2 jhux2 added type: enhancement Issue is an enhancement, not a bug pkg: MueLu labels Sep 24, 2021
@jhux2
Copy link
Member Author

jhux2 commented Sep 24, 2021

@mperrinel @ppebay

@GrahamBenHarper
Copy link
Contributor

@jhux2 , I'm not positive yet, but I think it's likely I'll be using MueLu_TpetraOperator a bit in upcoming research, so I can make sure to cover it when I get there.

@mayrmt
Copy link
Member

mayrmt commented Sep 27, 2021

@jhux2 I'm curious: Is the purpose of this issue just purely informative, so that we can work on improving test coverage as we do our regular developments, or is this to organize a coordinated effort to improve testing?

@jhux2
Copy link
Member Author

jhux2 commented Sep 27, 2021

@mayrmt NexGen (@JacobDomagala @mperrinel @ppebay) is improving MueLu's Kokkos testing coverage. The purpose of this issue is to prioritize the classes they look at. It's also informational for all of the @trilinos/muelu developers.

@trilinos/muelu If you see classes that you think should be prioritized, please bold them in the above check list.

@github-actions
Copy link

github-actions bot commented Nov 5, 2022

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Nov 5, 2022
@GrahamBenHarper
Copy link
Contributor

Do not close :)

@github-actions github-actions bot removed the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Nov 6, 2022
Copy link

github-actions bot commented Nov 8, 2023

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Nov 8, 2023
@GrahamBenHarper GrahamBenHarper added DO_NOT_AUTOCLOSE This issue should be exempt from auto-closing by the GitHub Actions bot. and removed MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. labels Nov 8, 2023
@GrahamBenHarper
Copy link
Contributor

bad bot >:(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO_NOT_AUTOCLOSE This issue should be exempt from auto-closing by the GitHub Actions bot. pkg: MueLu type: enhancement Issue is an enhancement, not a bug
Projects
Status: Backlog
Development

No branches or pull requests

3 participants