Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autogenerated files shouldn't be in the repository #90

Closed
milesrout opened this issue Jun 2, 2016 · 5 comments
Closed

Autogenerated files shouldn't be in the repository #90

milesrout opened this issue Jun 2, 2016 · 5 comments
Labels
build-process issues relating to the build, development or release processes enhancement very small feature or non-feature enhancement
Milestone
0.15 Basic ship b...

Comments

@milesrout
Copy link
Member

Unless they're very slow to generate and quite small or something, anyway.
@milesrout milesrout added the enhancement very small feature or non-feature enhancement label Jun 2, 2016
@ghost
Copy link

ghost commented Jun 2, 2016

Particularly refers to protobuf's .pb.cc/.pb.h files.

@adam4813
Copy link
Member

adam4813 commented Jun 2, 2016 via email

@milesrout
Copy link
Member Author

They can be generated by the normal engine process.

@milesrout milesrout added defect and removed enhancement very small feature or non-feature enhancement labels Jun 3, 2016
@milesrout milesrout added this to the 0.11.0 milestone Jun 4, 2016
@milesrout milesrout added the build-process issues relating to the build, development or release processes label Jun 6, 2016
@milesrout milesrout assigned ghost Jun 6, 2016
@ghost
Copy link

ghost commented Jun 11, 2016 •
edited by ghost
Loading

Here is what it takes to fix this issue: (CMakeLists.txt)

find_package(Protobuf REQUIRED)
protobuf_generate_cpp(COMPONENTS_SOURCES COMPONENTS_HEADERS ${trillek-common_SOURCE_DIR}/proto/components.proto)
protobuf_generate_cpp(GAME_STATE_SOURCES GAME_STATE_HEADERS ${trillek-common_SOURCE_DIR}/proto/game_state.proto)

Not closing this until the reworked build system is merged, though.

@adam4813
Copy link
Member

The latest commits add @danielekmann changes.

@milesrout milesrout added enhancement very small feature or non-feature enhancement and removed defect labels Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build-process issues relating to the build, development or release processes enhancement very small feature or non-feature enhancement
Projects
None yet
Milestone
0.15 Basic ship building
Development

No branches or pull requests
2 participants
@adam4813 @milesrout