Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove positional parameters in Member instantiation #9

Open
briangerard opened this issue Aug 17, 2016 · 1 comment
Open

Remove positional parameters in Member instantiation #9

briangerard opened this issue Aug 17, 2016 · 1 comment

Comments

@briangerard
Copy link
Contributor

The positional parameters to Member's init are long and ugly. As @aschrab suggested in his comment on #7, we should either instantiate using a dict, or create it empty and populate it field-by-field. I'm leaning toward the latter approach at present, but we'll see after some code.

@briangerard
Copy link
Contributor Author

These changes are on the simplify_member branch.

So far, it's testing well. The code looks a good bit cleaner, and feels a lot less fragile.

So far there's some unit testing in place, and I've done some testing in my home environment. I want to give it another once-over before putting in a pull request or merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant