Enable enableNullHandling query options in Pinot #22214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/pinot-null
branch
2 times, most recently
from
e9e94d6
to
0d20aae
Compare
ebyhr
commented
May 31, 2024
| @@ -341,14 +340,7 @@ else if (isFilterPushdownUnsupported(entry.getValue())) { | |||
| // See https://docs.pinot.apache.org/developers/advanced/null-value-support for more info. | |||
| private boolean isFilterPushdownUnsupported(Domain domain) | |||
| { | |||
| ValueSet valueSet = domain.getValues(); | |||
There was a problem hiding this comment.
Should we change the behavior based on enableColumnBasedNullHandling and dimensionFieldSpecs.notNull in a spec?
https://docs.pinot.apache.org/developers/advanced/null-value-support#store-nulls-at-ingestion-time
There was a problem hiding this comment.
Good idea! iirc it could be for any field spec (metricFieldSpecs, dateTimeFieldSpecs).
There was a problem hiding this comment.
I reverted changes in this method to minimize the scope of this PR. We can update it in follow-up.
wendigo
approved these changes
May 31, 2024
ebyhr
force-pushed
the
ebi/pinot-null
branch
7 times, most recently
from
2d0d346
to
e8e91b7
Compare
|
Rebased on master to resolve conflicts. |
elonazoulay
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable enableNullHandling query options in Pinot.
Release notes
(x) Release notes are required, with the following suggested text: