Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a more complete set of information from the JMX export of InternalResourceGroup #22957

Merged

Conversation

xkrogen
Copy link
Member

@xkrogen xkrogen commented Aug 6, 2024

Description

Add missing information from InternalResourceGroup to the set of metrics exposed when jmxExport = true to provide a more complete picture of the state of each resource group.

Additional context and related issues

Resource groups allow us to enable monitoring by using jmxExport = true (recently enabled by default in #20810, though subsequent reverted in #22185). However currently the set of information exposed by the resource group is restricted to a set of fields that seems fairly arbitrary to me, limiting the value. I would break the information into two categories: config information (e.g. what are the configured limits) and runtime information (e.g. how many queries are currently running). For this to be really useful, you need both things, so you can compare the current behavior against the limits, and you need a complete view of the picture. Below I list all of the fields from both categories, and the current status:

Type Field Currently Exposed?
Config SoftConcurrencyLimit NO
Config HardConcurrencyLimit YES
Config SoftMemoryLimitBytes NO
Config SoftCpuLimitMillis NO
Config HardCpuLimitMillis NO
Config CpuQuotaGenerationMillisPerSecond NO
Config MaxQueuedQueries YES
Config SchedulingWeight NO
Config SchedulingPolicy NO
Runtime RunningQueries YES
Runtime QueuedQueries YES
Runtime WaitingQueuedQueries YES
Runtime CpuUsageMillis NO
Runtime MemoryUsageBytes NO
Runtime TimeBetweenStartsSec YES

This PR exposes all of the fields that are marked with NO above, to consistently expose everything.

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(X) Release notes are required, with the following suggested text:

# General
* Expose additional JMX metrics about resource groups including cpu and memory usage, limits and scheduling policy in use. ({issue}`22957`)

@cla-bot cla-bot bot added the cla-signed label Aug 6, 2024
@xkrogen
Copy link
Member Author

xkrogen commented Aug 6, 2024

cc @phd3 @hashhar @wendigo

Copy link

github-actions bot commented Sep 2, 2024

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Sep 2, 2024
@hashhar hashhar merged commit ffce4a4 into trinodb:master Sep 3, 2024
95 checks passed
@github-actions github-actions bot added this to the 456 milestone Sep 3, 2024
@xkrogen xkrogen deleted the xkrogen/resource-group-expose-more-jmx-info branch September 3, 2024 15:44
@xkrogen
Copy link
Member Author

xkrogen commented Sep 3, 2024

Thanks for the review @hashhar !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants