Expose a more complete set of information from the JMX export of InternalResourceGroup #22957
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing information from
InternalResourceGroup
to the set of metrics exposed whenjmxExport = true
to provide a more complete picture of the state of each resource group.Additional context and related issues
Resource groups allow us to enable monitoring by using
jmxExport = true
(recently enabled by default in #20810, though subsequent reverted in #22185). However currently the set of information exposed by the resource group is restricted to a set of fields that seems fairly arbitrary to me, limiting the value. I would break the information into two categories: config information (e.g. what are the configured limits) and runtime information (e.g. how many queries are currently running). For this to be really useful, you need both things, so you can compare the current behavior against the limits, and you need a complete view of the picture. Below I list all of the fields from both categories, and the current status:This PR exposes all of the fields that are marked with NO above, to consistently expose everything.
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(X) Release notes are required, with the following suggested text: