Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazily read Prometheus response #23025

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Lazily read Prometheus response #23025

merged 1 commit into from
Sep 2, 2024

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Aug 13, 2024

Fixes #23013

Release notes: Fix reading large Prometheus responses

Copy link
Member

@losipiuk losipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change helps with response to large errors?

@electrum
Copy link
Member

electrum commented Sep 2, 2024

@losipiuk Previously, the ByteSource passed to PrometheusRecordCursor was a wrapped byte array. It's now an actual input stream from the OkHttp client.

@wendigo wendigo merged commit 92d301c into master Sep 2, 2024
16 checks passed
@wendigo wendigo deleted the serafin/lazy-prometheus branch September 2, 2024 05:46
@github-actions github-actions bot added this to the 456 milestone Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Collection of Prometheus response' fails with OOM error
3 participants