Fix for removing scheduler slowness due to sync call #10839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akashkatipally
approved these changes
Jan 28, 2022
|
@cla-bot check |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@hashhar I have submitted my cla via email today- hoping its approved soon |
|
Tests failed due to #6220 |
|
@riteshvaryani this one can be merged without CLA since it's merely a tiny fix |
sopel39
approved these changes
Jan 28, 2022
|
merged in #10841 |
|
Thanks @riteshvaryani !. I've preserved your authorship |
Closed
|
thank you @sopel39 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will run taskupdate in a separate thread and will not synchronize the call causing scheduler slowness.
Fixes bug introduced by 613bd2f
This fixes slowness in trino task update in the scheduler that is seen from version 360