-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sporadic failure: Expected operatorType to be PagesIndexBuilderOperator but was PageBufferOperator #6220
Comments
Observed on a fork https://github.com/findepi/presto/runs/1503892606?check_suite_focus=true but the tested branch has no execution related changes
|
cc @erichwang |
The underlying problem here is here: https://github.com/prestosql/presto/blob/master/presto-main/src/main/java/io/prestosql/operator/index/IndexBuildDriverFactoryProvider.java#L77 In the index join code, the same driver can dynamically have two different output types depending on whether the results are going to be streamed without caching, or cached. This is currently a decision that occurs at runtime based on how much memory is available in the cache, and so that might explain why this is non-deterministic. It seems like we have a couple options here:
This really comes down to how we want to tabulate these stats. Either way, none of these are going to be super clean since the execution framework isn't really set up for these exact operations. |
https://github.com/prestosql/presto/runs/1557282633
|
Could we make static (and settable via feature/session toggle)? |
We should fix this more properly, or maybe temporarily remove the check that was added until it is fixed. |
I think it's a good idea. |
https://github.com/trinodb/trino/runs/1644344275
|
Hit with #7214 |
That's what happened to me: |
https://github.com/trinodb/trino/runs/2771822401
|
https://github.com/trinodb/trino/runs/3144400785 (in #8645)
|
Relates to df4fe40 #6120
The text was updated successfully, but these errors were encountered: