Fix evictable cache invalidation race condition #22302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/fix-evictable-cache-invalidation-race-condition-f18e21
branch
from
d4115a0
to
e3f218d
Compare
findepi
force-pushed
the
findepi/fix-evictable-cache-invalidation-race-condition-f18e21
branch
from
e3f218d
to
edd6e34
Compare
losipiuk
reviewed
Jun 12, 2024
losipiuk
reviewed
Jun 12, 2024
losipiuk
approved these changes
Jun 12, 2024
Before the change the following race was possible between threads A, B, C: - A calls invalidate(K) - A increments: invalidations++ - B changes state to be cached, and therefore calls invalidate(K) too - B increments: invalidations++ - C calls get(K) - C reads invalidations counter - C retrieves current token T for key K - C reads value V for T from cache - A reads and removes token T (same) for key K - B attempts to read and remove token for key K, not found - B exits invalidate(K) - C checks invalidations counter (didn't check) - C revives, i.e. re-inserts token T for key K - B calls get(K) - B retrieves token T (same) for key K - B reads value V for T from cache -- despite B having called invalidate(K) At least in this situation the problem is transient. Thread A will momentarily invalidate dataCache for token T, completing the invalidation. This commit fixes this. The bug was introduced by token reviving (commit 17faae3). This commit reverts that one and provides a different solution to the problem that commit was solving.
findepi
force-pushed
the
findepi/fix-evictable-cache-invalidation-race-condition-f18e21
branch
from
97ead3c
to
9d535cc
Compare
findepi
deleted the
findepi/fix-evictable-cache-invalidation-race-condition-f18e21
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change the following race was possible between threads A, B, C:
At least in this situation the problem is transient. Thread A will momentarily invalidate dataCache for token T, completing the invalidation.
This commit fixes this. The bug was introduced by token reviving (commit 17faae3). This commit reverts that one and provides a different solution to the problem that commit was solving.
Fixes #22285
Release notes
(x) Release notes are required -- this fixes correctness problems in a couple different connectors.