Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky TestMongoDynamicFiltering.testJoinDynamicFilteringBlockProbeSide #21724

Closed
ebyhr opened this issue Apr 26, 2024 · 13 comments · Fixed by #22969
Closed

Flaky TestMongoDynamicFiltering.testJoinDynamicFilteringBlockProbeSide #21724

ebyhr opened this issue Apr 26, 2024 · 13 comments · Fixed by #22969
Assignees

Comments

@ebyhr
Copy link
Member

ebyhr commented Apr 26, 2024

Error:  io.trino.plugin.mongodb.TestMongoDynamicFiltering.testJoinDynamicFilteringBlockProbeSide -- Time elapsed: 0.802 s <<< FAILURE!
org.opentest4j.AssertionFailedError: 

expected: [1]
 but was: [39]
	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at io.trino.plugin.mongodb.TestMongoDynamicFiltering.assertDynamicFiltering(TestMongoDynamicFiltering.java:176)
	at io.trino.plugin.mongodb.TestMongoDynamicFiltering.testJoinDynamicFilteringBlockProbeSide(TestMongoDynamicFiltering.java:160)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:507)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.tryRemoveAndExec(ForkJoinPool.java:1534)
	at java.base/java.util.concurrent.ForkJoinPool.helpJoin(ForkJoinPool.java:2269)
	at java.base/java.util.concurrent.ForkJoinTask.awaitDone(ForkJoinTask.java:495)
	at java.base/java.util.concurrent.ForkJoinTask.join(ForkJoinTask.java:662)
	at java.base/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:507)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1491)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:2073)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:2035)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:187)

https://github.com/trinodb/trino/actions/runs/8837410508/job/24266264851

@ZhangJianAo
Copy link
Contributor

I can't reproduce the error on my laptop. Is there any way to rerun the action?

@ebyhr
Copy link
Member Author

ebyhr commented Apr 28, 2024

1/1000 failed on my laptop. Please try @RepeatedTest annotation.

@ebyhr
Copy link
Member Author

ebyhr commented Apr 30, 2024

@ebyhr
Copy link
Member Author

ebyhr commented May 9, 2024

@ebyhr
Copy link
Member Author

ebyhr commented May 17, 2024

@ebyhr
Copy link
Member Author

ebyhr commented Jun 5, 2024

@ebyhr
Copy link
Member Author

ebyhr commented Jun 5, 2024

@ZhangJianAo Any updates?

@ZhangJianAo
Copy link
Contributor

This test runs the following sql:

SELECT l.comment FROM  lineitem l, part p, orders o WHERE
    l.orderkey = o.orderkey
    AND o.comment = 'nstructions sleep furiously among '
    AND p.partkey = l.partkey
    AND p.comment = 'onic deposits'

Normally there should be two column filters in dynamic filter, one for partkey, another for orderkey.

Screen Shot 2024-06-06 at 19 00 12

But sometimes, there is only one column filter in the dynamic filter:

Screen Shot 2024-06-06 at 18 52 13

I have noticed the futuresLeft is 1 when there is only one column filter. I am digging to find out why.

@findepi
Copy link
Member

findepi commented Jun 11, 2024

@ebyhr
Copy link
Member Author

ebyhr commented Jul 26, 2024

@ebyhr
Copy link
Member Author

ebyhr commented Jul 26, 2024

@ZhangJianAo Could you share the current status?

@ebyhr
Copy link
Member Author

ebyhr commented Aug 6, 2024

@ZhangJianAo Reminder.

@sopel39 sopel39 assigned sopel39 and unassigned ZhangJianAo Aug 6, 2024
@sopel39
Copy link
Member

sopel39 commented Aug 6, 2024

Found issue, will create PR later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants