Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Field fails if content types are renamed. #491

Closed
laceysanderson opened this issue Jun 28, 2018 · 5 comments
Closed

Remote Field fails if content types are renamed. #491

laceysanderson opened this issue Jun 28, 2018 · 5 comments
Labels
bug - confirmed For issues where a core developer has confirmed a bug exists. PR Submitted A pull request has been submitted and is awaiting review. Release Blocker Any issue which needs to be addressed before another version of Tripal can be released. Tripal 3 Any issue or pull requuest focused on Tripal 3

Comments

@laceysanderson
Copy link
Member

BUG/ERROR report

Originally reported when testing PR #439

System information

  • Tripal Version: 3-dev
  • Drupal Version: 7.x

Issue description

If admin of remote sites change the name of their content types the Remote Field will not work. This seems to be due to it not using the configured query. For example, when my organism content type is re-named to Species I see the following error in my remote field (configured to point at my own dev site):

This is despite my field being configured to query Species?genus=Lens&species=culinaris see config. I've confirmed that changing the name back to Organism fixes the field.

Steps to reproduce

  1. Set-up a remote field on your organism content type and confirm it works.
  2. Edit the content type at Admin > Structure > Tripal Content Types > Organism > Edit and change the Name: Species.
  3. Clear the cache and then refresh your organism page. Your field which was working will now be showing an error.
@laceysanderson laceysanderson added bug - confirmed For issues where a core developer has confirmed a bug exists. Tripal 3 Any issue or pull requuest focused on Tripal 3 Release Blocker Any issue which needs to be addressed before another version of Tripal can be released. labels Jun 28, 2018
@shawnawsu
Copy link
Member

Hi @laceysanderson I just tested this on my local and am unable to reproduce, ie the query does change when I change it in the field settings of the remote data field. Can you confirm this is still an issue?

@almasaeed2010
Copy link
Contributor

Hello @laceysanderson and @shawnawsu

I tested this by following the steps to reproduce mentioned above and managed to replicate the issue:

This is the error I get:

screen shot 2018-07-24 at 9 02 18 am

@almasaeed2010
Copy link
Contributor

I am also getting this error now:

Notice: Undefined variable: remote_entity_link in remote__data_formatter->view() (line 151 of /Sites/Tripal/sites/all/modules/tripal/tripal_ws/includes/TripalFields/remote__data/remote__data_formatter.inc).

spficklin added a commit that referenced this issue Aug 11, 2018
@spficklin spficklin added the PR Submitted A pull request has been submitted and is awaiting review. label Aug 11, 2018
@spficklin
Copy link
Member

Okay, I have submitted a fix via a PR for this. Can you both test it and let me know how it goes?

@laceysanderson
Copy link
Member Author

Fixed via PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug - confirmed For issues where a core developer has confirmed a bug exists. PR Submitted A pull request has been submitted and is awaiting review. Release Blocker Any issue which needs to be addressed before another version of Tripal can be released. Tripal 3 Any issue or pull requuest focused on Tripal 3
Projects
None yet
Development

No branches or pull requests

4 participants