-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1815 Handle locked (or not locked) materialized views better functionality #1877
Conversation
Uniqueness is determined by table name + schema
This matches the recent change to the custom table view
Looks like I somehow forgot to follow the branch naming guide this time, oops! I'll resubmit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @Ferrisx4 that your code must not all be pushed. I'm not seeing the changes shown in the screenshot. There is no "locked" column in the mviews page, and the action doesn't default to "populate" like it shows.
Oops, I had word wrap enabled in my editor, didn't realize the length of the comment. Thanks for the quick fix @spficklin For the display issues, the changes on the Custom Tables and Materialized Views views are not picked up automatically. If you did not reinstall Tripal, they will not appear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the display issues, the changes on the Custom Tables and Materialized Views views are not picked up automatically. If you did not reinstall Tripal, they will not appear.
You will want to add an update hook then. It looks like the changes are all config related 🤔 and I don't know off my head how to trigger a rediscover of that so you'll need to do some searching.
Ok thanks @laceysanderson I will look into it! |
@Ferrisx4, I know how to trigger a reload of config files. Message me on Slack and I'll show you how. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some testing on a docker built on this branch and came across the following:
I get the following error when I edit an unlocked materialized view:
The following worked as expected:
- locked column was filled as expected
- default actions change as expected
- editing a locked materialized view was not allowed
- editing a locked custom table was not allowed
- editing an unlocked custom table was successful without error.
- action buttons worked as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also build a new docker on 4.x, confirmed that the changes in this PR were not seen, then switched to this branch and cleared the cache. At this point the changed did appear as expected ✅ This shows that the error Stephen first found showing that the config had not been updated has been fixed by the additions to the rebuild command in this PR.
Hi @laceysanderson, I believe I've fixed the error you found above. The form['locked'] form element was only available when the form's action was set to "add" and not when it was "edit". When editing, the locked value is now picked up from the database and saved in a 'value' form element to make it available for submission. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thanks, this is ready to merge now 🎉
Bug Fix
Issue #1815
Tripal Version: 4
Description
This PR adds or modifies several functionalities related to custom tables and materialized views:
Visual
Make "Populate" the default action on the materialized view list; edit is a dropdown action now.
The locked status of custom tables and materialized views is now shown in their respective listings on
![Screen Shot 2024-05-14 at 10 37 38 AM](https://private-user-images.githubusercontent.com/9593623/330479202-e1675eb1-14d1-4ee2-849c-3502cf0d48d1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQxNzM3MjIsIm5iZiI6MTcyNDE3MzQyMiwicGF0aCI6Ii85NTkzNjIzLzMzMDQ3OTIwMi1lMTY3NWViMS0xNGQxLTRlZTItODQ5Yy0zNTAyY2YwZDQ4ZDEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjBUMTcwMzQyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YmRlMzJiMzc2OGRjNWNiZjk1YTYwNTYzOGIwNThiMjc4MTgwMzc5YWZmNDQ4ZmU3YjRmNjBmYzdiMDkxNjVjNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.xvblWB9laD1xnUZ-DlbeBLDeUuhDk1EHx_dh6OlFdco)
admin/tripal/storage/chado/custom_tables
andadmin/tripal/storage/chado/mviews
On the Custom Tables page, add a blurb about what these are and how to find their respective materialized views.
On the Custom Tables and Materialized Views lists, the filter now has a description.
![Screen Shot 2024-05-14 at 10 35 28 AM](https://private-user-images.githubusercontent.com/9593623/330478029-8177d76a-29a2-41f4-8e06-40ed4de279b5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQxNzM3MjIsIm5iZiI6MTcyNDE3MzQyMiwicGF0aCI6Ii85NTkzNjIzLzMzMDQ3ODAyOS04MTc3ZDc2YS0yOWEyLTQxZjQtOGUwNi00MGVkNGRlMjc5YjUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjBUMTcwMzQyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9Y2I4YmFiOGU5YzE3M2IyZmE3ODQ0NWIxN2Q0ZmE0ZGY1ZGU0NTczZDM4NDIzYmJmNzA3NTczZTdjN2U5ZWMyNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.CqUJMJZDIC4LPmReH_mZ4D5ME2TpGktb12n9KMQ7ZxA)
Functional
Testing?