Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.6: Trying to open a save game on a map that you don't have downloaded fails without error message #10523

Closed
asvitkine opened this issue May 29, 2022 · 1 comment · Fixed by #12586
Assignees
Labels
2.6 Problem A problem, bug, defect - something to fix Regression A problem introduced in pre-release and not present in latest release

Comments

@asvitkine
Copy link
Contributor

Reproduction Steps

  1. Open a save game for a map that doesn't exist.
  2. Start the game.

Expected: A dialog box saying the map doesn't exist, would you like to download it? (like in 2.5)
Actual: Game fails silently during load and reverts to game lobby screen.

Attach a Save Game

I tried it with this 2.5 save on ww2 global expansion, which I didn't have:
2.5-example-save.tsvg.zip

Engine Version

Engine Version: 2.6.811

Is there anything else we should know?

@asvitkine asvitkine added Problem A problem, bug, defect - something to fix Regression A problem introduced in pre-release and not present in latest release labels May 29, 2022
@asvitkine asvitkine added the 2.6 label Jul 4, 2023
@asvitkine
Copy link
Contributor Author

The code for this used to be here:

+ ", could not join game.\nWould you like to download the map now?"

Looks like that code moved around in the file a bit, but its removal was here:
https://github.com/triplea-game/triplea/pull/9775/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.6 Problem A problem, bug, defect - something to fix Regression A problem introduced in pre-release and not present in latest release
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant