Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern Warfare project ready to be uploaded #10914

Open
Cestmoi02 opened this issue Jul 29, 2022 · 27 comments
Open

Modern Warfare project ready to be uploaded #10914

Cestmoi02 opened this issue Jul 29, 2022 · 27 comments

Comments

@Cestmoi02
Copy link

I have made a map, "Modern Warfare", which I believe is ready to be released for playtesting. Please send me an invitation at triplea-maps. Below you can find the link to the repository.
Thank you and best wishes,
Cestmoi02

https://github.com/Cestmoi02/modern_warfare.git

@beelee1
Copy link
Contributor

beelee1 commented Jul 30, 2022

@Cestmoi02 yea I don't think you need an invitation anymore. @asvitkine did a new one recently. @RogerCooper has done quite a few. They can probably clue you in on how to proceed

@Cestmoi02
Copy link
Author

Ok, thanks. I was followning the guide here: https://docs.google.com/document/d/1FfF7N0srp9QG0_if5D-c1d1Aa1QTttdhxgm1GBh3pI4/edit step 6. I'll see what I can do from here. Thanks again for the help

@RogerCooper
Copy link
Contributor

The next step is adding it to triplea_maps.yaml. Let me know if you need any help. I could do it myself if you want.

@Cestmoi02
Copy link
Author

I've added it myself (or at least I've made a pull request). If it works, I'll close this thread. Thank you once again for the help :)

@beelee1
Copy link
Contributor

beelee1 commented Jul 31, 2022

@Cestmoi02 hmm ... not seeing it. Open or closed. Can you link to it ?

@Cestmoi02
Copy link
Author

As a complete noob, I forgot to click the green "open pull request" button. Hopefully it's on now.

@beelee1
Copy link
Contributor

beelee1 commented Jul 31, 2022

:)

@beelee1
Copy link
Contributor

beelee1 commented Jul 31, 2022

looks like its working. Takes a few minutes to finish. 👍

@Cestmoi02
Copy link
Author

@RogerCooper I think I am going to take up on your offer for help :), as the way I did it, it returns an error on "checkstyle and formatting"...

@RogerCooper
Copy link
Contributor

I added it in. Once the merge is approved, it will be available for download. Adding mods is not an easy task.

@Cestmoi02
Copy link
Author

I see it returned an error. The path to my map was wrong, because it is not yet hosted on triplea-maps. I tried transfering the ownership to the organization, but it said that I am not authorized to do that. Is there any other way to make it appear in triplea-maps or to receive authorization?

@RogerCooper
Copy link
Contributor

I will try posting it myself this weekend. You created a folder under your name, that may have been the issue. Every other map has been posted to a folder directly off the main folder. The posting process is quite finicky.

@Cestmoi02
Copy link
Author

Thanks. It would be nice to tell me afterwards (or beforehand) how you've done it, as both guides I've found on how to upload a map seem out-of-date and I don't want to be bailed out by others for every map I make ;)

@TheDog-GH
Copy link
Contributor

@RogerCooper
Please write on update on how to upload a map to GitHub.
A one liner bullet point list, for each step would be great as a starting point.

@RogerCooper
Copy link
Contributor

I have some notes that I will write up.

@Cestmoi02
Copy link
Author

I don't want to be annoying or anything, but any progress?

@TheDog-GH
Copy link
Contributor

@Cestmoi02
He is a busy guy, but he is on it, give him a few more days, see here. :-)
https://forums.triplea-game.org/topic/3277/posting-scenarios-to-the-repository

@RogerCooper
Copy link
Contributor

Modern Warfare is next.

@RogerCooper
Copy link
Contributor

I got it to run my computer, the first step towards upload.

The AI seems to have some trouble playing the Americans, massing its army on the Mexican border, instead of moving against the enemy (Gregg Abbott is President I guess). Maybe make the Latin American neutrals their own country, allied with the US but having no turn.

@Cestmoi02
Copy link
Author

On my PC they would invade the Arab League and the pro-russian South American states regularly... it could be because I tested it on Fast AI. Russia also really needs Fast AI, because otherwise it turtles in Russia. With Fast AI it invades Ukraine, the Baltic States and Turkey and aims for the European industrial heartland.

Anyway, let's keep this thread for the technical challanges of uploading a map. I made a thread on the TripleA forum for discussing the map itself: https://forums.triplea-game.org/topic/3276/modern-warfare-official-thread

@RogerCooper
Copy link
Contributor

I posted the scenario myself and I see that it is available for download. The description I put in was minimal, you should be able to update the mod description in triplea_maps.yaml

@beelee1
Copy link
Contributor

beelee1 commented Aug 13, 2022

@Cestmoi02 I would go ahead and close this

@Cestmoi02
Copy link
Author

Oh yeah upsy, sorry. I'll close it right away. Thank you all for the help, especially @RogerCooper :)

@Cestmoi02
Copy link
Author

Sorry to reopen this, but I wanted to play this with a friend. He downloaded the map, but upon hitting "play", he received an error "failed to start game ... unable to load expected resource: polygons.txt".

I could reproduce the error... it happened on my PC, as well, when I used the downloaded version. Any help would be appreciated.

PS: Medieval Europe suffers the same fate

@Cestmoi02 Cestmoi02 reopened this Aug 15, 2022
@TheDog-GH
Copy link
Contributor

@Cestmoi02
Its better to open map problems here
https://forums.triplea-game.org/category/5/maps-mods
more people will help you. I know you don't want to clutter up your actual Official thread, so open up a new one. 😉
GitHub is mainly used by the Devs and they are too busy doing Dev things 😁

I can reproduce it, my fix is to unzip your map and delete the zip or a variant on that. Another work around is to download a version of 2.6 that will also unzip ALL zipped maps.

As to the actual problem, I dont know, but at least you both can play.

@beelee1
Copy link
Contributor

beelee1 commented Aug 15, 2022

I believe Dog is correct. You need to rename the unzipped folder so the -master isn't on anymore as well if I remember right

@DanVanAtta DanVanAtta reopened this Sep 3, 2022
@DanVanAtta
Copy link
Member

@Cestmoi02 did this get fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants