Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameDataManager#loadGame:62 - java.util.zip.ZipException #11257

Open
tripleabuilderbot opened this issue Nov 28, 2022 · 2 comments
Open

GameDataManager#loadGame:62 - java.util.zip.ZipException #11257

tripleabuilderbot opened this issue Nov 28, 2022 · 2 comments
Labels
2.6 Error Report Issue reported via the in-game error reporter

Comments

@tripleabuilderbot
Copy link
Contributor

Log Message

Error loading game data

TripleA Version

2.6.14220

Java Version

11.0.9.1

Operating System

Windows 10

Stack Trace

Exception: java.util.zip.ZipException Not in GZIP format
java.lang.Exception
	at java.base/java.util.zip.GZIPInputStream.readHeader(GZIPInputStream.java:166)
	at java.base/java.util.zip.GZIPInputStream.<init>(GZIPInputStream.java:80)
	at java.base/java.util.zip.GZIPInputStream.<init>(GZIPInputStream.java:92)
	at games.strategy.engine.framework.GameDataManager.loadGame(GameDataManager.java:62)
	at games.strategy.engine.framework.GameDataManager.loadGame(GameDataManager.java:47)
	at games.strategy.engine.framework.startup.ui.panels.main.game.selector.GameSelectorModel.load(GameSelectorModel.java:76)
	at games.strategy.engine.framework.startup.ui.panels.main.game.selector.GameSelectorPanel.lambda$loadSaveFile$6(GameSelectorPanel.java:370)
	at games.strategy.engine.framework.ui.background.TaskRunner$1.doInBackground(TaskRunner.java:79)
	at games.strategy.engine.framework.ui.background.TaskRunner$1.doInBackground(TaskRunner.java:75)
	at java.desktop/javax.swing.SwingWorker$1.call(SwingWorker.java:304)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.desktop/javax.swing.SwingWorker.run(SwingWorker.java:343)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)


@tripleabuilderbot tripleabuilderbot added 2.6 Error Report Issue reported via the in-game error reporter labels Nov 28, 2022
@asvitkine
Copy link
Contributor

I think this happens if you try to open some random file with triplea. The code is literally:

      // try to load it as a saved game whatever the extension
      final GameData newData = GameDataManager.loadGame(xmlFile).orElse(null);

So probably a WontFix, but I guess we could try to catch the error and not report it.

@frigoref
Copy link
Member

frigoref commented Jul 2, 2024

@asvitkine Could we flag that as nice to have as this is all to user handling is you and a change would bring little benefit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.6 Error Report Issue reported via the in-game error reporter
Projects
None yet
Development

No branches or pull requests

3 participants