Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OWG and MG Support #39

Open
trippsc2 opened this issue Oct 21, 2020 · 5 comments
Open

OWG and MG Support #39

trippsc2 opened this issue Oct 21, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@trippsc2
Copy link
Owner

Add OWG and MG support.

@trippsc2 trippsc2 self-assigned this Oct 21, 2020
@trippsc2 trippsc2 added the enhancement New feature or request label Oct 21, 2020
@Berserker66
Copy link

Fair warning that multiworld has OWG and minor glitches and can mix them with any ER mode. Because of ER support, we don't have MG yet, as ER logic gets real messy and noone has as of yet wrapped their heads around it.

@trippsc2
Copy link
Owner Author

Thank you for the heads up. I'm aware that dungeon logic gets strange for MG, but wasn't aware that it wasn't compatible with entrance shuffle yet. I've been hesitant to work on this because I don't fully understand glitched modes.

@Berserker66
Copy link

One of the core issues is that MG relies on importing "dungeon state", and the way that the ER state graph works no state can currently ever be lost. You just get states/events/items, never lose them. But to accurately represent MG logic with ER shuffle this would likely need to added, unless someone can find a smart way to do it within the current logic system confines.

As for ALTTPR; it is either glitched logic or ER, it cannot mix the two, at all.

@Berserker66
Copy link

Berserker66 commented Jan 3, 2021

Recently I reviewed a lot of glitch logic and fixed a fair few bugs with it. That is now all covered by over 12000 unittests in archipelago:
https://github.com/Berserker66/MultiWorld-Utilities/tree/main/test
(If using pycharm -> right click folder -> run unittests in /test)
image

Pointing this out as a resource if it happens to be helpful here.
Covers Minor Glitches and OWG, no MG as of yet.

@Berserker66
Copy link

Hybrid Major Glitches has been in AP for a few months now. Compatible with all other modes, including all forms of Entrance Rando.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants