Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using flat Vectors for DGMulti #1240

Open
jlchan opened this issue Oct 19, 2022 · 0 comments
Open

Switch to using flat Vectors for DGMulti #1240

jlchan opened this issue Oct 19, 2022 · 0 comments
Assignees
Labels

Comments

@jlchan
Copy link
Contributor

jlchan commented Oct 19, 2022

DGMulti uses either Vector{<:SVector} or StructArray{SVector} to represent it solutions. However, OrdinaryDiffEq.jl's precompilation is designed for Vector{Float64} types. Switching DGMulti's representation to Vector and using wrap_array to convert this Vector to either

  1. a Vector reinterpreted as an array of SVector
  2. a StructArray{SVector} constructed from views into a contiguous vector
    should enable us to take advantage of OrdinaryDiffEq.jl's precompilation.

Additionally, Julia can only resize Vector{Float64} types, so if we want to put adaptivity into DGMulti, we probably have to do this anyways.

@jlchan jlchan self-assigned this Oct 19, 2022
@jlchan jlchan changed the title Try using flat Vectors for DGMulti Switch to using flat Vectors for DGMulti Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants