Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce source code in dirent_mbstowcs_s() #26

Closed
elfring opened this issue Jan 30, 2019 · 1 comment
Closed

Reduce source code in dirent_mbstowcs_s() #26

elfring opened this issue Jan 30, 2019 · 1 comment

Comments

@elfring
Copy link

elfring commented Jan 30, 2019

How do you think about to replace an if statement at the end of the function “dirent_mbstowcs_s” by the shorter statement “return (n > 0 && flag == 0) ? 0 : 1;”?
@tronkko
Copy link
Owner

tronkko commented Feb 2, 2019

I generally prefer if statement. I think if statement is more readable and easier to understand.

@tronkko tronkko closed this as completed Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elfring @tronkko