Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onchange(items) event not fired #167

Closed
jffaust opened this issue Jun 15, 2015 · 3 comments
Closed

onchange(items) event not fired #167

jffaust opened this issue Jun 15, 2015 · 3 comments

Comments

@jffaust
Copy link
Contributor

jffaust commented Jun 15, 2015

The event is not fired when calling remove_widget with floating disabled. Let's say I have multiple widgets all in one column and I call remove_widget for the top widget. Since floating is disabled, all the widgets are pushed to the top, their attributes are changed (data-gs-x and data-gs-y) but the event about widgets changing position isn't called.

I think it shouldn't be hard/long to fix but I don't understand the code well enough to do the change myself.

Thank you

@mgwidmann
Copy link
Contributor

👍 I'm not seeing the change event fired on add or remove. Either it should do a self.container.trigger('change', [self.grid.get_dirty_nodes()]); or trigger an add/remove specific event.

@piwi91
Copy link

piwi91 commented Jun 30, 2015

👍 I miss this too

@piwi91
Copy link

piwi91 commented Jul 22, 2015

@troolee is there a workaround for this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants