Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the deprecated GuzzleHttp parse_response method #297

Merged
merged 1 commit into from Feb 8, 2022
Merged

fix the deprecated GuzzleHttp parse_response method #297

merged 1 commit into from Feb 8, 2022

Conversation

MinaWilliam
Copy link
Contributor

parse_response has been deprecated and replaced with Message::parseResponse.

@MolloKhan
Copy link

This is exactly the fix I'm looking for. Could somebody merge it?

@BrandonSurowiec
Copy link

I just ran into this error when my composer updated the Guzzle PSR7 package from v1.8.3 to v2.1:

Call to undefined function GuzzleHttp\Psr7\parse_response()

1. File /vendor/troydavisson/phrets/src/Parsers/GetObject/Multiple.php line 52

In the 2.0 branch, these helper functions, like parse_response, were removed:
guzzle/psr7#381

But they have aliases as of v1.7:
guzzle/psr7#345

@troydavisson Any chance of getting this PR merged?

@deevoweb
Copy link

I guess this package is dead. Probably ought to just fork it and fix the things that need to be fixed.

Copy link

@deevoweb deevoweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should do it.

@MinaWilliam
Copy link
Contributor Author

I guess this package is dead. Probably ought to just fork it and fix the things that need to be fixed.

Yes, I did that

@deevoweb
Copy link

You did good. @troydavisson can we get a merge on this one? I don't want to have to use a custom branch in my project if I don't have to :(

@bfjare
Copy link

bfjare commented Jan 31, 2022

Getting this as well. Thanks @deevoweb

@MolloKhan
Copy link

I guess this package is dead. Probably ought to just fork it and fix the things that need to be fixed.

I did just that https://github.com/larzuk91/PHRETS

@troydavisson troydavisson merged commit b2d0158 into troydavisson:master Feb 8, 2022
@MolloKhan
Copy link

Thanks for making it happen @troydavisson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants