Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 18 strip forbidden header(s?) automatically? #2420

Closed
KATT opened this issue Aug 10, 2022 · 2 comments
Closed

Node 18 strip forbidden header(s?) automatically? #2420

KATT opened this issue Aug 10, 2022 · 2 comments

Comments

@KATT
Copy link
Member

KATT commented Aug 10, 2022

See #2085

In order for SSR to work, we need to at a minimum strip the connection header when forwarding the headers from the browser.

  • Are there other headers we need to strip than connection?
  • Should we do this automatically? Should then then be configurable?

Example how to fix SSR in Node 18 SSR: KATT/unidici-fetch-reserved-header-crap#1

@KATT KATT changed the title Node 18 strip forbidden headers automatically? Node 18 strip forbidden header(s?) automatically? Aug 10, 2022
@KATT
Copy link
Member Author

KATT commented Sep 13, 2022

Caveats are in docs now

@KATT KATT closed this as not planned Won't fix, can't repro, duplicate, stale Sep 13, 2022
@github-actions
Copy link

github-actions bot commented Oct 4, 2022

This issue has been locked because it had no new activity for 14 days. If you are running into a similar issue, please create a new issue. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

1 participant