chore: pruned some never-used code #3487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JoshuaKGoldberg is attempting to deploy a commit to the trpc Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JoshuaKGoldberg
commented
Dec 26, 2022
| @@ -14,6 +14,7 @@ | |||
| "test-watch": "cd packages/tests && pnpm test-watch", | |||
| "lint": "eslint --ext \".js,.ts,.tsx\" --ignore-path .gitignore .", | |||
| "lint-fix": "pnpm lint --fix && manypkg fix", | |||
| "lint-prune": "! ts-prune | grep -v \"used in module\"", | |||
There was a problem hiding this comment.
Once nadeesha/ts-prune#202 lands, this can be simplified.
JoshuaKGoldberg
requested review from
KATT,
trpc-bot and
sachinraja
as code owners
KATT
previously approved these changes
Dec 26, 2022
.github/workflows/lint-prune.yml
Outdated
| run: pnpm install --child-concurrency 3 | ||
|
|
||
| - name: Run ts-prune | ||
| run: pnpm lint-prune |
There was a problem hiding this comment.
Can we move the lint pruning job into the lint.yml?
There was a problem hiding this comment.
Sure, I'll do that now. I personally prefer a handful of separate jobs so you get more granular reporting in parallel. Is there any particular reason to keep them together?
sachinraja
approved these changes
Dec 26, 2022
KATT
approved these changes
Dec 26, 2022
kodiakhq bot
added a commit
to weareinreach/InReach
that referenced
this pull request
Jan 6, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@trpc/client](https://trpc.io) ([source](https://togithub.com/trpc/trpc)) | [`10.7.0` -> `10.8.1`](https://renovatebot.com/diffs/npm/@trpc%2fclient/10.7.0/10.8.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@trpc/next](https://trpc.io) ([source](https://togithub.com/trpc/trpc)) | [`10.7.0` -> `10.8.1`](https://renovatebot.com/diffs/npm/@trpc%2fnext/10.7.0/10.8.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@trpc/react-query](https://trpc.io) ([source](https://togithub.com/trpc/trpc)) | [`10.7.0` -> `10.8.1`](https://renovatebot.com/diffs/npm/@trpc%2freact-query/10.7.0/10.8.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@trpc/server](https://trpc.io) ([source](https://togithub.com/trpc/trpc)) | [`10.7.0` -> `10.8.1`](https://renovatebot.com/diffs/npm/@trpc%2fserver/10.7.0/10.8.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) | [`1.10.15` -> `1.10.16`](https://renovatebot.com/diffs/npm/libphonenumber-js/1.10.15/1.10.16) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [quicktype-core](https://togithub.com/quicktype/quicktype) | [`7.0.2` -> `7.0.3`](https://renovatebot.com/diffs/npm/quicktype-core/7.0.2/7.0.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>trpc/trpc</summary> ### [`v10.8.1`](https://togithub.com/trpc/trpc/releases/tag/v10.8.1) [Compare Source](https://togithub.com/trpc/trpc/compare/v10.8.0...v10.8.1) ##### What's Changed - chore: bump `peerDependencies` between `@trpc/*`-packages by [@​KATT](https://togithub.com/KATT) **Full Changelog**: trpc/trpc@v10.8.0...v10.8.1 ### [`v10.8.0`](https://togithub.com/trpc/trpc/releases/tag/v10.8.0) [Compare Source](https://togithub.com/trpc/trpc/compare/v10.7.0...v10.8.0) ##### What's Changed - feat(client): add base client for integrations by [@​bautistaaa](https://togithub.com/bautistaaa) & [@​KATT](https://togithub.com/KATT) in [trpc/trpc#3389, [trpc/trpc#3479 - chore: deprecate usage of `createHooksInternal` by [@​KATT](https://togithub.com/KATT) in [trpc/trpc#3480 - chore: pruned some never-used code by [@​JoshuaKGoldberg](https://togithub.com/JoshuaKGoldberg) in [trpc/trpc#3487 - fix(react-query): fix import from dist folder by [@​gspetrou](https://togithub.com/gspetrou) in [trpc/trpc#3499 - feat: accept function param in `initTRPC.context` by [@​juliusmarminge](https://togithub.com/juliusmarminge) in [trpc/trpc#3495 - feat: handle reserved properties key collisions by [@​sachinraja](https://togithub.com/sachinraja) in [trpc/trpc#3466 - feat(react-query): added `initialData` overloads for `useQuery` by [@​JoshuaKGoldberg](https://togithub.com/JoshuaKGoldberg) in [trpc/trpc#3500 - feat: add `resHeaders` to fetch-adapter's `createContext` by [@​sachinraja](https://togithub.com/sachinraja) in [trpc/trpc#3532 - Add cloudflare-page-plugin-trpc into the Awesome tRPC collection list by [@​toyamarinyon](https://togithub.com/toyamarinyon) in [trpc/trpc#3531 - fix(client): use constant of websocket impl by [@​nohum](https://togithub.com/nohum) in [trpc/trpc#3542 - chore(client): rm redundant `getLinks()` from client factory by [@​KATT](https://togithub.com/KATT) in [trpc/trpc#3541 ##### New Contributors - [@​JoshuaKGoldberg](https://togithub.com/JoshuaKGoldberg) made their first contribution in [trpc/trpc#3482 - [@​mishankov](https://togithub.com/mishankov) made their first contribution in [trpc/trpc#3492 - [@​guushamann](https://togithub.com/guushamann) made their first contribution in [trpc/trpc#3493 - [@​gspetrou](https://togithub.com/gspetrou) made their first contribution in [trpc/trpc#3499 - [@​zihan-ch](https://togithub.com/zihan-ch) made their first contribution in [trpc/trpc#3511 - [@​roj1512](https://togithub.com/roj1512) made their first contribution in [trpc/trpc#3515 - [@​nfabredev](https://togithub.com/nfabredev) made their first contribution in [trpc/trpc#3457 - [@​hrstmr](https://togithub.com/hrstmr) made their first contribution in [trpc/trpc#3519 **Full Changelog**: trpc/trpc@v10.7.0...v10.8.0 </details> <details> <summary>catamphetamine/libphonenumber-js</summary> ### [`v1.10.16`](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.10.15...v1.10.16) [Compare Source](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.10.15...v1.10.16) </details> <details> <summary>quicktype/quicktype</summary> ### [`v7.0.3`](https://togithub.com/quicktype/quicktype/compare/5dbf11c85037e3f6a1ae842cf124c14546827a43...90a6bc16e854c337955ea453fe36a6d7fcd17c99) [Compare Source](https://togithub.com/quicktype/quicktype/compare/5dbf11c85037e3f6a1ae842cf124c14546827a43...90a6bc16e854c337955ea453fe36a6d7fcd17c99) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/weareinreach/InReach). PR-URL: #141 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #I was told to just go nuts 🥳🎯 Changes
Removes some things in code that aren't referenced anywhere else and aren't an example or exported by an
index.tsfile.Adds ts-prune to detect these automatically.
✅ Checklist