protected intersection for vanilla client

[sachinraja]

Closes #3530

Naming a procedure something that conflicts with a TRPCUntypedClient property is now a type error.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
next-prisma-starter	✅ Ready (Inspect)	Visit Preview		Jan 30, 2023 at 6:05AM (UTC)
og-image	✅ Ready (Inspect)	Visit Preview		Jan 30, 2023 at 6:05AM (UTC)
www	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Jan 30, 2023 at 6:05AM (UTC)

[KATT]

Is there a reason we wouldn't do this on the backend?

trpc/packages/server/src/core/router.ts

Lines 159 to 168 in 4fab2f1

	/**
	* Reserved words that can't be used as router or procedure names
	*/
	const reservedWords = [
	/**
	* Then is a reserved word because otherwise we can't return a promise that returns a Proxy
	* since JS will think that `.then` is something that exists
	*/
	'then',
	];

[juliusmarminge]

Is there a reason we wouldn't do this on the backend?

trpc/packages/server/src/core/router.ts

Lines 159 to 168 in 4fab2f1

	/**
	* Reserved words that can't be used as router or procedure names
	*/
	const reservedWords = [
	/**
	* Then is a reserved word because otherwise we can't return a promise that returns a Proxy
	* since JS will think that `.then` is something that exists
	*/
	'then',
	];

This was my initial thought too - the earlier the error the better. Pretty "annoying" making the entire router just to go on the frontend and see you used reserved keywords so you have to come up with new names

[juliusmarminge]

I guess the difference is that then should be banned on all levels deep while e.g. links only needs to be banned at depth 1 if that makes sense?

[KATT]

This is good.

For next major I think we should do some _-prefix or something to make these less rare. I don't like that we are blocking a generic word like "links" because we need it for some internals

[sachinraja]

Is there a reason we wouldn't do this on the backend?

It's not a problem if you're using the React or Next client.

I guess the difference is that then should be banned on all levels deep while e.g. links only needs to be banned at depth 1 if that makes sense?

Also correct

For next major I think we should do some _-prefix or something to make these less rare. I don't like that we are blocking a generic word like "links" because we need it for some internals

I think we'd be better off just moving to a functional API. I have some ideas on how to do that.

[dotansimha]

Seems like this PR removed inferRouterProxyClient - what's the alternative? we noticed this breaking change in v10.9.1 (kamilkisiela/graphql-hive#1195)

[juliusmarminge]

Is there a reason we wouldn't do this on the backend?
It's not a problem if you're using the React or Next client

The problem would still occur when doing

const utils = trpc.useContext();
utils.client.links

No?