fix(client): skip calling .abort() on AbortController after procedure completion
#4788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kamilogorek
reviewed
Sep 11, 2023
KATT
changed the title
server): skip calling .abort() on AbortController after query completion
KATT
changed the title
server): skip calling .abort() on AbortController after query completionserver): skip calling .abort() on AbortController after procedure completion
KATT
changed the title
server): skip calling .abort() on AbortController after procedure completionclient): skip calling .abort() on AbortController after procedure completion
KATT
commented
Sep 12, 2023
| ``` | ||
|
|
||
| in the project root directory. This will make sure all the build artifacts and codegen has run. After that, you can run the tests in watch mode using |
There was a problem hiding this comment.
lol, i didn't even know this
kamilogorek
reviewed
Sep 12, 2023
|
|
||
| ``` | ||
| ```bash |
There was a problem hiding this comment.
#protip ```shell also works :)
juliusmarminge
approved these changes
Sep 12, 2023
kamilogorek
reviewed
Sep 12, 2023
| @@ -194,11 +196,14 @@ export function httpRequest( | |||
| }); | |||
| }) | |||
| .catch((err) => { | |||
| done = true; | |||
| reject(TRPCClientError.from(err, { meta })); | |||
| }); | |||
There was a problem hiding this comment.
You can also use .finally(() => { done = true; }); to have everything in one place.
There was a problem hiding this comment.
Unfortunately I can't because calling reject()/resolve() causes a race condition that gets to the cleanup function before .finally() is executed
kamilogorek
reviewed
Sep 12, 2023
| reject(TRPCClientError.from(err, { meta })); | ||
| }); | ||
| }); | ||
| const cancel = () => { | ||
| ac?.abort(); | ||
| if (!done) { |
There was a problem hiding this comment.
That works as a workaround, but I wonder why observable is even cancelling it in the first place? Or is it just a generic "cleanup" function?
There was a problem hiding this comment.
Yeah, there might be something to what you're saying here
There was a problem hiding this comment.
Two years since I wrote the observable-stuff, my memory is rust, but I think it's a generic cleanup, but could prob be improved
kodiakhq bot
pushed a commit
to weareinreach/InReach
that referenced
this pull request
Sep 12, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@aws-sdk/client-cognito-identity-provider](https://togithub.com/aws/aws-sdk-js-v3/tree/main/clients/client-cognito-identity-provider) ([source](https://togithub.com/aws/aws-sdk-js-v3)) | [`3.409.0` -> `3.410.0`](https://renovatebot.com/diffs/npm/@aws-sdk%2fclient-cognito-identity-provider/3.409.0/3.410.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@opentelemetry/api](https://togithub.com/open-telemetry/opentelemetry-js/tree/main/api) ([source](https://togithub.com/open-telemetry/opentelemetry-js)) | [`1.5.0` -> `1.6.0`](https://renovatebot.com/diffs/npm/@opentelemetry%2fapi/1.5.0/1.6.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@opentelemetry/exporter-trace-otlp-http](https://togithub.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/exporter-trace-otlp-http) ([source](https://togithub.com/open-telemetry/opentelemetry-js)) | [`0.42.0` -> `0.43.0`](https://renovatebot.com/diffs/npm/@opentelemetry%2fexporter-trace-otlp-http/0.42.0/0.43.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@opentelemetry/instrumentation](https://togithub.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/opentelemetry-instrumentation) ([source](https://togithub.com/open-telemetry/opentelemetry-js)) | [`0.42.0` -> `0.43.0`](https://renovatebot.com/diffs/npm/@opentelemetry%2finstrumentation/0.42.0/0.43.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@opentelemetry/resources](https://togithub.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-resources) ([source](https://togithub.com/open-telemetry/opentelemetry-js)) | [`1.16.0` -> `1.17.0`](https://renovatebot.com/diffs/npm/@opentelemetry%2fresources/1.16.0/1.17.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@opentelemetry/sdk-node](https://togithub.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/opentelemetry-sdk-node) ([source](https://togithub.com/open-telemetry/opentelemetry-js)) | [`0.42.0` -> `0.43.0`](https://renovatebot.com/diffs/npm/@opentelemetry%2fsdk-node/0.42.0/0.43.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@opentelemetry/sdk-trace-base](https://togithub.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-sdk-trace-base) ([source](https://togithub.com/open-telemetry/opentelemetry-js)) | [`1.16.0` -> `1.17.0`](https://renovatebot.com/diffs/npm/@opentelemetry%2fsdk-trace-base/1.16.0/1.17.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@opentelemetry/sdk-trace-node](https://togithub.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-sdk-trace-node) ([source](https://togithub.com/open-telemetry/opentelemetry-js)) | [`1.16.0` -> `1.17.0`](https://renovatebot.com/diffs/npm/@opentelemetry%2fsdk-trace-node/1.16.0/1.17.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@opentelemetry/semantic-conventions](https://togithub.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-semantic-conventions) ([source](https://togithub.com/open-telemetry/opentelemetry-js)) | [`1.16.0` -> `1.17.0`](https://renovatebot.com/diffs/npm/@opentelemetry%2fsemantic-conventions/1.16.0/1.17.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@trpc/client](https://trpc.io) ([source](https://togithub.com/trpc/trpc)) | [`10.38.1` -> `10.38.2`](https://renovatebot.com/diffs/npm/@trpc%2fclient/10.38.1/10.38.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@trpc/next](https://trpc.io) ([source](https://togithub.com/trpc/trpc)) | [`10.38.1` -> `10.38.2`](https://renovatebot.com/diffs/npm/@trpc%2fnext/10.38.1/10.38.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@trpc/react-query](https://trpc.io) ([source](https://togithub.com/trpc/trpc)) | [`10.38.1` -> `10.38.2`](https://renovatebot.com/diffs/npm/@trpc%2freact-query/10.38.1/10.38.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@trpc/server](https://trpc.io) ([source](https://togithub.com/trpc/trpc)) | [`10.38.1` -> `10.38.2`](https://renovatebot.com/diffs/npm/@trpc%2fserver/10.38.1/10.38.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/aws-lambda](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/aws-lambda) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | [`8.10.119` -> `8.10.120`](https://renovatebot.com/diffs/npm/@types%2faws-lambda/8.10.119/8.10.120) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@typescript-eslint/parser](https://togithub.com/typescript-eslint/typescript-eslint) | [`6.6.0` -> `6.7.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/6.6.0/6.7.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [tsx](https://togithub.com/esbuild-kit/tsx) | [`3.12.8` -> `3.12.9`](https://renovatebot.com/diffs/npm/tsx/3.12.8/3.12.9) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>aws/aws-sdk-js-v3 (@​aws-sdk/client-cognito-identity-provider)</summary> ### [`v3.410.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-cognito-identity-provider/CHANGELOG.md#34100-2023-09-11) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.409.0...v3.410.0) **Note:** Version bump only for package [@​aws-sdk/client-cognito-identity-provider](https://togithub.com/aws-sdk/client-cognito-identity-provider) </details> <details> <summary>open-telemetry/opentelemetry-js (@​opentelemetry/api)</summary> ### [`v1.6.0`](https://togithub.com/open-telemetry/opentelemetry-js/blob/HEAD/CHANGELOG.md#160) [Compare Source](https://togithub.com/open-telemetry/opentelemetry-js/compare/v1.5.0...v1.6.0) ##### 🚀 (Enhancement) - perf(opentelemetry-core): improve hexToBase64 performance [#​3178](https://togithub.com/open-telemetry/opentelemetry-js/pull/3178) [@​seemk](https://togithub.com/seemk) - feat(sdk-trace-base): move Sampler declaration into sdk-trace-base [#​3088](https://togithub.com/open-telemetry/opentelemetry-js/pull/3088) [@​legendecas](https://togithub.com/legendecas) - fix(grpc-instrumentation): added grpc attributes in instrumentation [#​3127](https://togithub.com/open-telemetry/opentelemetry-js/pull/3127) [@​andrewzenkov](https://togithub.com/andrewzenkov) - feat: support latest `@opentelemetry/api` [#​3177](https://togithub.com/open-telemetry/opentelemetry-js/pull/3177) [@​dyladan](https://togithub.com/dyladan) ##### 🐛 (Bug Fix) - fix(context-async-hooks): Ensure listeners added using `once` can be removed using `removeListener` [#​3133](https://togithub.com/open-telemetry/opentelemetry-js/pull/3133) ##### 📚 (Refine Doc) - chore: update trace-web example and rename it to opentelemetry-web [#​3145](https://togithub.com/open-telemetry/opentelemetry-js/pull/3145) [@​pichlermarc](https://togithub.com/pichlermarc) - chore: update https example [#​3152](https://togithub.com/open-telemetry/opentelemetry-js/pull/3152) [@​pichlermarc](https://togithub.com/pichlermarc) </details> <details> <summary>trpc/trpc (@​trpc/client)</summary> ### [`v10.38.2`](https://togithub.com/trpc/trpc/releases/tag/v10.38.2) [Compare Source](https://togithub.com/trpc/trpc/compare/v10.38.1...v10.38.2) #### What's Changed - fix(`server`): allow adding charset after `application/json` by [@​KATT](https://togithub.com/KATT) in [trpc/trpc#4787 - fix(`client`): skip calling `.abort()` on AbortController after procedure completion by [@​KATT](https://togithub.com/KATT) in [trpc/trpc#4788 #### New Contributors - [@​larskarbo](https://togithub.com/larskarbo) made their first contribution in [trpc/trpc#4776 **Full Changelog**: trpc/trpc@v10.38.1...v10.38.2 </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v6.7.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#670-2023-09-11) [Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.6.0...v6.7.0) **Note:** Version bump only for package [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>esbuild-kit/tsx (tsx)</summary> ### [`v3.12.9`](https://togithub.com/esbuild-kit/tsx/releases/tag/v3.12.9) [Compare Source](https://togithub.com/esbuild-kit/tsx/compare/v3.12.8...v3.12.9) ##### Bug Fixes - suppress import assertion warning ([#​300](https://togithub.com/esbuild-kit/tsx/issues/300)) ([3745548](https://togithub.com/esbuild-kit/tsx/commit/3745548b1328ceddb7a0f96d35f8b8f904f78571)) - upgrade esm-loader & suppress `globalPreload` warning ([#​308](https://togithub.com/esbuild-kit/tsx/issues/308)) ([f295c50](https://togithub.com/esbuild-kit/tsx/commit/f295c506acc30ba9d88e01e0e8530db81a3dd36c)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/weareinreach/InReach). PR-URL: #759 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
kodiakhq bot
added a commit
to weareinreach/TransMascFutures
that referenced
this pull request
Sep 12, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@storybook/addon-a11y](https://togithub.com/storybookjs/storybook/tree/next/code/addons/a11y) ([source](https://togithub.com/storybookjs/storybook)) | [`7.4.0` -> `7.4.1`](https://renovatebot.com/diffs/npm/@storybook%2faddon-a11y/7.4.0/7.4.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/addon-essentials](https://togithub.com/storybookjs/storybook/tree/next/code/addons/essentials) ([source](https://togithub.com/storybookjs/storybook)) | [`7.4.0` -> `7.4.1`](https://renovatebot.com/diffs/npm/@storybook%2faddon-essentials/7.4.0/7.4.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/addon-interactions](https://togithub.com/storybookjs/storybook/tree/next/code/addons/interactions) ([source](https://togithub.com/storybookjs/storybook)) | [`7.4.0` -> `7.4.1`](https://renovatebot.com/diffs/npm/@storybook%2faddon-interactions/7.4.0/7.4.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/addon-links](https://togithub.com/storybookjs/storybook/tree/next/code/addons/links) ([source](https://togithub.com/storybookjs/storybook)) | [`7.4.0` -> `7.4.1`](https://renovatebot.com/diffs/npm/@storybook%2faddon-links/7.4.0/7.4.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/addon-viewport](https://togithub.com/storybookjs/storybook/tree/next/code/addons/viewport) ([source](https://togithub.com/storybookjs/storybook)) | [`7.4.0` -> `7.4.1`](https://renovatebot.com/diffs/npm/@storybook%2faddon-viewport/7.4.0/7.4.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/blocks](https://togithub.com/storybookjs/storybook/tree/next/code/ui/blocks) ([source](https://togithub.com/storybookjs/storybook)) | [`7.4.0` -> `7.4.1`](https://renovatebot.com/diffs/npm/@storybook%2fblocks/7.4.0/7.4.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/nextjs](https://togithub.com/storybookjs/storybook/tree/next/code/frameworks/nextjs) ([source](https://togithub.com/storybookjs/storybook)) | [`7.4.0` -> `7.4.1`](https://renovatebot.com/diffs/npm/@storybook%2fnextjs/7.4.0/7.4.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/react](https://togithub.com/storybookjs/storybook/tree/next/code/renderers/react) ([source](https://togithub.com/storybookjs/storybook)) | [`7.4.0` -> `7.4.1`](https://renovatebot.com/diffs/npm/@storybook%2freact/7.4.0/7.4.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@trpc/client](https://trpc.io) ([source](https://togithub.com/trpc/trpc)) | [`10.38.1` -> `10.38.2`](https://renovatebot.com/diffs/npm/@trpc%2fclient/10.38.1/10.38.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@trpc/next](https://trpc.io) ([source](https://togithub.com/trpc/trpc)) | [`10.38.1` -> `10.38.2`](https://renovatebot.com/diffs/npm/@trpc%2fnext/10.38.1/10.38.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@trpc/react-query](https://trpc.io) ([source](https://togithub.com/trpc/trpc)) | [`10.38.1` -> `10.38.2`](https://renovatebot.com/diffs/npm/@trpc%2freact-query/10.38.1/10.38.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@trpc/server](https://trpc.io) ([source](https://togithub.com/trpc/trpc)) | [`10.38.1` -> `10.38.2`](https://renovatebot.com/diffs/npm/@trpc%2fserver/10.38.1/10.38.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | [`18.17.14` -> `18.17.15`](https://renovatebot.com/diffs/npm/@types%2fnode/18.17.14/18.17.15) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/typescript-eslint) | [`6.6.0` -> `6.7.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/6.6.0/6.7.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@typescript-eslint/parser](https://togithub.com/typescript-eslint/typescript-eslint) | [`6.6.0` -> `6.7.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/6.6.0/6.7.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [eslint](https://eslint.org) ([source](https://togithub.com/eslint/eslint)) | [`8.48.0` -> `8.49.0`](https://renovatebot.com/diffs/npm/eslint/8.48.0/8.49.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [pnpm](https://pnpm.io) ([source](https://togithub.com/pnpm/pnpm)) | [`8.7.4` -> `8.7.5`](https://renovatebot.com/diffs/npm/pnpm/8.7.4/8.7.5) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [prettier-plugin-jsdoc](https://togithub.com/hosseinmd/prettier-plugin-jsdoc) | [`1.0.1` -> `1.0.2`](https://renovatebot.com/diffs/npm/prettier-plugin-jsdoc/1.0.1/1.0.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [storybook](https://togithub.com/storybookjs/storybook/tree/next/code/lib/cli) ([source](https://togithub.com/storybookjs/storybook)) | [`7.4.0` -> `7.4.1`](https://renovatebot.com/diffs/npm/storybook/7.4.0/7.4.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [tsx](https://togithub.com/esbuild-kit/tsx) | [`3.12.8` -> `3.12.9`](https://renovatebot.com/diffs/npm/tsx/3.12.8/3.12.9) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>storybookjs/storybook (@​storybook/addon-a11y)</summary> ### [`v7.4.1`](https://togithub.com/storybookjs/storybook/blob/HEAD/CHANGELOG.md#741) [Compare Source](https://togithub.com/storybookjs/storybook/compare/v7.4.0...v7.4.1) - CLI: Add uncaughtException handler - [#​24018](https://togithub.com/storybookjs/storybook/pull/24018), thanks [@​yannbf](https://togithub.com/yannbf)! - CLI: Fix packageManager handling in `sb add` - [#​24079](https://togithub.com/storybookjs/storybook/pull/24079), thanks [@​Integrayshaun](https://togithub.com/Integrayshaun)! - Core: Add CJS entrypoints to errors in core events - [#​24038](https://togithub.com/storybookjs/storybook/pull/24038), thanks [@​yannbf](https://togithub.com/yannbf)! - Docs: Fix TOC import - [#​24047](https://togithub.com/storybookjs/storybook/pull/24047), thanks [@​shilman](https://togithub.com/shilman)! - Telemetry: Filter addon options to protect sensitive info - [#​24000](https://togithub.com/storybookjs/storybook/pull/24000), thanks [@​shilman](https://togithub.com/shilman)! - Types: Remove `@types/react` dep from `@storybook/types` - [#​24042](https://togithub.com/storybookjs/storybook/pull/24042), thanks [@​JReinhold](https://togithub.com/JReinhold)! - Vue3: Remove console.log in sourceDecorator - [#​24062](https://togithub.com/storybookjs/storybook/pull/24062), thanks [@​oruman](https://togithub.com/oruman)! </details> <details> <summary>trpc/trpc (@​trpc/client)</summary> ### [`v10.38.2`](https://togithub.com/trpc/trpc/releases/tag/v10.38.2) [Compare Source](https://togithub.com/trpc/trpc/compare/v10.38.1...v10.38.2) #### What's Changed - fix(`server`): allow adding charset after `application/json` by [@​KATT](https://togithub.com/KATT) in [trpc/trpc#4787 - fix(`client`): skip calling `.abort()` on AbortController after procedure completion by [@​KATT](https://togithub.com/KATT) in [trpc/trpc#4788 #### New Contributors - [@​larskarbo](https://togithub.com/larskarbo) made their first contribution in [trpc/trpc#4776 **Full Changelog**: trpc/trpc@v10.38.1...v10.38.2 </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v6.7.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#670-2023-09-11) [Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.6.0...v6.7.0) ##### Bug Fixes - **eslint-plugin:** \[no-restricted-imports] disallow side effect imports when allowTypeImports is enabled ([#​7560](https://togithub.com/typescript-eslint/typescript-eslint/issues/7560)) ([4908905](https://togithub.com/typescript-eslint/typescript-eslint/commit/4908905e4ee2b533504fcba0c671aa869668df25)) ##### Features - **eslint-plugin:** \[await-thenable] added suggestion fixer ([#​7437](https://togithub.com/typescript-eslint/typescript-eslint/issues/7437)) ([b284370](https://togithub.com/typescript-eslint/typescript-eslint/commit/b284370e1e95493764d2806cd45975201e02f374)) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v6.7.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#670-2023-09-11) [Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.6.0...v6.7.0) **Note:** Version bump only for package [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>eslint/eslint (eslint)</summary> ### [`v8.49.0`](https://togithub.com/eslint/eslint/releases/tag/v8.49.0) [Compare Source](https://togithub.com/eslint/eslint/compare/v8.48.0...v8.49.0) ##### Features - [`da09f4e`](https://togithub.com/eslint/eslint/commit/da09f4e641141f585ef611c6e9d63d4331054706) feat: Implement onUnreachableCodePathStart/End ([#​17511](https://togithub.com/eslint/eslint/issues/17511)) (Nicholas C. Zakas) - [`32b2327`](https://togithub.com/eslint/eslint/commit/32b2327aafdd3b911fabab69ed75c9ff97658c60) feat: Emit deprecation warnings in RuleTester ([#​17527](https://togithub.com/eslint/eslint/issues/17527)) (Nicholas C. Zakas) - [`acb7df3`](https://togithub.com/eslint/eslint/commit/acb7df35b9a7485f26bc6b3e1f9083d1c585dce9) feat: add new `enforce` option to `lines-between-class-members` ([#​17462](https://togithub.com/eslint/eslint/issues/17462)) (Nitin Kumar) ##### Documentation - [`ecfb54f`](https://togithub.com/eslint/eslint/commit/ecfb54ff4cdd18f28b4f9b78f0a78fb4cf80f1b8) docs: Update README (GitHub Actions Bot) - [`de86b3b`](https://togithub.com/eslint/eslint/commit/de86b3b2e58edd5826200c23255d8325abe375e1) docs: update `no-promise-executor-return` examples ([#​17529](https://togithub.com/eslint/eslint/issues/17529)) (Nitin Kumar) - [`032c4b1`](https://togithub.com/eslint/eslint/commit/032c4b1476a7b8cfd917a66772d2221950ea87eb) docs: add typescript template ([#​17500](https://togithub.com/eslint/eslint/issues/17500)) (James) - [`cd7da5c`](https://togithub.com/eslint/eslint/commit/cd7da5cc3154f86f7ca45fb58929d27a7af359ed) docs: Update README (GitHub Actions Bot) ##### Chores - [`b7621c3`](https://togithub.com/eslint/eslint/commit/b7621c3b16cf7d5539f05336a827e1b32d95e6ac) chore: remove browser test from `npm test` ([#​17550](https://togithub.com/eslint/eslint/issues/17550)) (Milos Djermanovic) - [`cac45d0`](https://togithub.com/eslint/eslint/commit/cac45d04b890b0700dd8908927300608adad05fe) chore: upgrade [@​eslint/js](https://togithub.com/eslint/js)[@​8](https://togithub.com/8).49.0 ([#​17549](https://togithub.com/eslint/eslint/issues/17549)) (Milos Djermanovic) - [`cd39508`](https://togithub.com/eslint/eslint/commit/cd395082bffcb4b68efa09226d7c682cef56179e) chore: package.json update for [@​eslint/js](https://togithub.com/eslint/js) release (ESLint Jenkins) - [`203a971`](https://togithub.com/eslint/eslint/commit/203a971c0abc3a95ae02ff74104a01e569707060) ci: bump actions/checkout from 3 to 4 ([#​17530](https://togithub.com/eslint/eslint/issues/17530)) (dependabot\[bot]) - [`a40fa50`](https://togithub.com/eslint/eslint/commit/a40fa509922b36bb986eb1be9394591f84f62d9e) chore: use eslint-plugin-jsdoc's flat config ([#​17516](https://togithub.com/eslint/eslint/issues/17516)) (Milos Djermanovic) - [`926a286`](https://togithub.com/eslint/eslint/commit/926a28684282aeec37680bbc52a66973b8055f54) test: replace Karma with Webdriver.IO ([#​17126](https://togithub.com/eslint/eslint/issues/17126)) (Christian Bromann) - [`f591d2c`](https://togithub.com/eslint/eslint/commit/f591d2c88bf15af72e3a207b34fa872b4b90464b) chore: Upgrade config-array ([#​17512](https://togithub.com/eslint/eslint/issues/17512)) (Nicholas C. Zakas) </details> <details> <summary>pnpm/pnpm (pnpm)</summary> ### [`v8.7.5`](https://togithub.com/pnpm/pnpm/releases/tag/v8.7.5) [Compare Source](https://togithub.com/pnpm/pnpm/compare/v8.7.4...v8.7.5) #### Patch Changes - Improve performance of installation by using a worker for creating the symlinks inside `node_modules/.pnpm` [#​7069](https://togithub.com/pnpm/pnpm/pull/7069). - Tarballs that have hard links are now unpacked successfully. This fixes a regression introduced in v8.7.0, which was shipped with our new in-house tarball parser [#​7062](https://togithub.com/pnpm/pnpm/pull/7062). #### Our Gold Sponsors <table> <tbody> <tr> <td align="center" valign="middle"> <a href="https://bit.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://pnpm.io/img/users/bit.svg" width="80"></a> </td> <td align="center" valign="middle"> <a href="https://novu.co/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/novu.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/novu_light.svg" /> <img src="https://pnpm.io/img/users/novu.svg" width="180" /> </picture> </a> </td> </tr> <tr> <td align="center" valign="middle"> <a href="https://prisma.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/prisma.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/prisma_light.svg" /> <img src="https://pnpm.io/img/users/prisma.svg" width="180" /> </picture> </a> </td> <td align="center" valign="middle"> <a href="https://www.flightcontrol.dev/?ref=pnpm" target="_blank"><img src="https://pnpm.io/img/users/flightcontrol.svg" width="240"></a> </td> </tr> </tbody> </table> #### Our Silver Sponsors <table> <tbody> <tr> <td align="center" valign="middle"> <a href="https://leniolabs.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <img src="https://pnpm.io/img/users/leniolabs.jpg" width="80"> </a> </td> <td align="center" valign="middle"> <a href="https://vercel.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/vercel.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/vercel_light.svg" /> <img src="https://pnpm.io/img/users/vercel.svg" width="180" /> </picture> </a> </td> </tr> <tr> <td align="center" valign="middle"> <a href="https://depot.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/depot.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/depot_light.svg" /> <img src="https://pnpm.io/img/users/depot.svg" width="200" /> </picture> </a> </td> <td align="center" valign="middle"> <a href="https://moonrepo.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/moonrepo.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/moonrepo_light.svg" /> <img src="https://pnpm.io/img/users/moonrepo.svg" width="200" /> </picture> </a> </td> </tr> <tr> <td align="center" valign="middle"> <a href="https://www.thinkmill.com.au/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/thinkmill.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/thinkmill_light.svg" /> <img src="https://pnpm.io/img/users/thinkmill.svg" width="200" /> </picture> </a> </td> <td align="center" valign="middle"> <a href="https://devowl.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"> <picture> <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/devowlio.svg" /> <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/devowlio.svg" /> <img src="https://pnpm.io/img/users/devowlio.svg" width="200" /> </picture> </a> </td> </tr> </tbody> </table> </details> <details> <summary>hosseinmd/prettier-plugin-jsdoc (prettier-plugin-jsdoc)</summary> ### [`v1.0.2`](https://togithub.com/hosseinmd/prettier-plugin-jsdoc/blob/HEAD/CHANGELOG.md#102-2023-09-09) [Compare Source](https://togithub.com/hosseinmd/prettier-plugin-jsdoc/compare/v1.0.1...v1.0.2) </details> <details> <summary>esbuild-kit/tsx (tsx)</summary> ### [`v3.12.9`](https://togithub.com/esbuild-kit/tsx/releases/tag/v3.12.9) [Compare Source](https://togithub.com/esbuild-kit/tsx/compare/v3.12.8...v3.12.9) ##### Bug Fixes - suppress import assertion warning ([#​300](https://togithub.com/esbuild-kit/tsx/issues/300)) ([3745548](https://togithub.com/esbuild-kit/tsx/commit/3745548b1328ceddb7a0f96d35f8b8f904f78571)) - upgrade esm-loader & suppress `globalPreload` warning ([#​308](https://togithub.com/esbuild-kit/tsx/issues/308)) ([f295c50](https://togithub.com/esbuild-kit/tsx/commit/f295c506acc30ba9d88e01e0e8530db81a3dd36c)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/weareinreach/GLAAD). PR-URL: #169 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4750
🎯 Changes
.abort()on AbortController after procedure completionpostinstallincludes everything fortest-watchto work:-tasks means something that is run in parallel best on arun-p x:*-command✅ Checklist