fix(server): sets TRPCError.name to TRPCError regardless of what bundlers do

[dios-david]

🎯 Changes

Setting this.name to "TRPCError" in the TRPCError constructor instead of using this.constructor.name.

Background

I ran into an issue with my trpc server where the production build of the server incorrectly returned 500 INTERNAL_SERVER_ERROR instead of 400 BAD_REQUEST for validation errors happening in procedures.

After some debugging I noticed that in the production bundle the TRPCError class got renamed to TRPCError2 (I'm using vite with vite-plugin-node):

let TRPCError$6 = class TRPCError2 extends Error {
  constructor(opts) {
    const cause = getCauseFromUnknown$1(opts.cause);
    const message2 = opts.message ?? cause?.message ?? opts.code;
    super(message2, {
      cause
    });
    this.code = opts.code;
    this.name = this.constructor.name;
  }
};

Which then fails this check in trpc-openapi:

export function getErrorFromUnknown(cause: unknown): TRPCError {
  if (cause instanceof Error && cause.name === 'TRPCError') { // <-- `cause.name` is `TRPCError2` here
    return cause as TRPCError;
  }

I understand that @trpc/server is correctly doing this.name = this.constructor.name in TRPCError, and should not really be aware of further issues which are caused by bundlers and a 3rd party trpc wrapper (trpc-openapi), but:

• It's really easy to fix this issue in @trpc/server itself, and there is nothing wrong with hardcoding this.name of Errors, especially if other packages build logic on that
• Before this PR the value of this.name was hardcoded to TRPCError which got changed to a dynamic this.constructor.name, but the scope of that PR did not required this change

✅ Checklist

• I have followed the steps listed in the Contributing guide.
• If necessary, I have added documentation related to the changes made.
• I have added or updated the tests related to the changes made.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
trpc-next-app-dir	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 27, 2023 11:02pm
www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 27, 2023 11:02pm

[vercel]

@dios-david is attempting to deploy a commit to the trpc Team on Vercel.

A member of the Team first needs to authorize it.