fix(server + client): incorrect inferred input type when using standalone middleware #4973

jussisaurio · 2023-10-28T20:10:29Z

…wares

🎯 Changes

The previous fix fixed _input_out which resolved the incorrect types on the server side when defining the procedure, but still had incorrect _input_in types, which clients use.

Similar fix as before: do a merge of the _input_in types similarly as with _input_out.

✅ Checklist

I have followed the steps listed in the Contributing guide.
If necessary, I have added documentation related to the changes made.
I have added or updated the tests related to the changes made.

vercel · 2023-10-28T20:10:36Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
next-prisma-starter	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 1, 2023 4:53pm
og-image	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 1, 2023 4:53pm
trpc-next-app-dir	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 1, 2023 4:53pm
www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 1, 2023 4:53pm

jussisaurio · 2023-10-29T09:17:43Z

This is almost 100% unrelated to this PR, but BTW: currently using unstable_pipe with this feature does not work if you're defining required input types for the middlewares. It works with ctx because the context modification/propagation in middlewares is already implemented, but since you can't currently define a standalone middleware chain like:

const chain = input(someSchema).use(someMwThatRequiresInput); // not attached to `t.procedure` yet!

Then all attempts to unstable_pipe from middleware A to middleware B will fail if B requires something that A doesn't require. The correct way to do this would be that mwA.unstable_pipe(mwB) would result in a middleware where the input is an intersection of A and B's requirements.

Dunno if anyone currently has any real use cases for a combination of experimental_standaloneMiddleware and unstable_pipe, but something to think about.

I have this nagging feeling that to get the optimal API for different middleware use cases, some sort of rewrite of MiddlewareBuilder is probably necessary, but I haven't had the time or mindshare to sit down and actually think what that would look like.

juliusmarminge · 2023-11-01T13:43:29Z

packages/tests/server/regression/issue-4947-merged-middleware-inputs.test.ts

+  expectTypeOf(proc._def._input_in).toEqualTypeOf<{
+    valueA: string;
+    valueB: string;
+    extraProp: string;
+  }>();
+
+  expectTypeOf(proc._def._input_out).toEqualTypeOf<{
+    valueA: string;
+    valueB: string;
+    extraProp: string;
+  }>();


should we add some test when the input is transformed to make sure that also works as expected?

I can add one to this test later today once I get off work

I modified the test to test the types from tRPC's public types only, not private types

…wares The previous fix fixed _input_out which resolved the incorrect types on the server side when defining the procedure, but still had incorrect _input_in types, which clients use. Similar fix as before: do a merge of the _input_in types similarly as with _input_out.

These are not necessary to make input merging with experimental_standaloneMiddleware work and were added erroneously before. Removing them gets rid of unnecessary typescript compiler work.

jussisaurio requested a review from a team as a code owner October 28, 2023 20:10

vercel bot deployed to Preview – next-prisma-starter October 28, 2023 20:10 View deployment

github-actions bot added the @trpc/server label Oct 28, 2023

vercel bot deployed to Preview – og-image October 28, 2023 20:10 View deployment

vercel bot deployed to Preview – todomvc October 28, 2023 20:11 View deployment

vercel bot deployed to Preview – www October 28, 2023 20:12 View deployment

vercel bot deployed to Preview – trpc-next-app-dir October 28, 2023 20:12 View deployment

vercel bot deployed to Preview – next-prisma-starter October 29, 2023 08:51 View deployment

vercel bot deployed to Preview – og-image October 29, 2023 08:51 View deployment

vercel bot deployed to Preview – todomvc October 29, 2023 08:51 View deployment

vercel bot deployed to Preview – trpc-next-app-dir October 29, 2023 08:51 View deployment

vercel bot deployed to Preview – next-prisma-starter October 29, 2023 08:55 View deployment

vercel bot deployed to Preview – og-image October 29, 2023 08:56 View deployment

vercel bot deployed to Preview – todomvc October 29, 2023 08:56 View deployment

vercel bot deployed to Preview – trpc-next-app-dir October 29, 2023 08:58 View deployment

vercel bot deployed to Preview – www October 29, 2023 08:58 View deployment

vercel bot deployed to Preview – next-prisma-starter October 29, 2023 08:59 View deployment

vercel bot deployed to Preview – og-image October 29, 2023 08:59 View deployment

vercel bot deployed to Preview – todomvc October 29, 2023 08:59 View deployment

vercel bot deployed to Preview – trpc-next-app-dir October 29, 2023 09:00 View deployment

vercel bot deployed to Preview – www October 29, 2023 09:00 View deployment

juliusmarminge reviewed Nov 1, 2023

View reviewed changes

juliusmarminge previously approved these changes Nov 1, 2023

View reviewed changes

jussisaurio added 5 commits November 1, 2023 18:27

Explicitly call procedure in #4947 regression test to verify inputs

7127eec

Remove unnecessary UnsetMarker usages

ecccb79

These are not necessary to make input merging with experimental_standaloneMiddleware work and were added erroneously before. Removing them gets rid of unnecessary typescript compiler work.

Fix formatting issues

28bcb89

Modify test to test public API types, not private types

581a6a6

jussisaurio dismissed juliusmarminge’s stale review via 581a6a6 November 1, 2023 16:41

jussisaurio force-pushed the fix-4972 branch from 968bd91 to 581a6a6 Compare November 1, 2023 16:41

vercel bot deployed to Preview – next-prisma-starter November 1, 2023 16:42 View deployment

vercel bot deployed to Preview – og-image November 1, 2023 16:42 View deployment

vercel bot deployed to Preview – todomvc November 1, 2023 16:42 View deployment

vercel bot deployed to Preview – trpc-next-app-dir November 1, 2023 16:44 View deployment

vercel bot deployed to Preview – www November 1, 2023 16:53 View deployment

jussisaurio requested a review from juliusmarminge November 2, 2023 07:58

KATT approved these changes Nov 2, 2023

View reviewed changes

KATT changed the title ~~fix #4972: incorrect inferred input type when using standalone middle…~~ fix(server + client): incorrect inferred input type when using standalone middleware Nov 2, 2023

KATT merged commit fa36f73 into main Nov 2, 2023
36 checks passed

KATT deleted the fix-4972 branch November 2, 2023 09:52

renovate bot mentioned this pull request Nov 10, 2023

fix(deps): update all non-major dependencies weareinreach/InReach-bot#50

Merged

1 task

github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(server + client): incorrect inferred input type when using standalone middleware #4973

fix(server + client): incorrect inferred input type when using standalone middleware #4973

jussisaurio commented Oct 28, 2023

vercel bot commented Oct 28, 2023 •

edited

jussisaurio commented Oct 29, 2023 •

edited

juliusmarminge Nov 1, 2023

jussisaurio Nov 1, 2023

jussisaurio Nov 1, 2023

fix(server + client): incorrect inferred input type when using standalone middleware #4973

fix(server + client): incorrect inferred input type when using standalone middleware #4973

Conversation

jussisaurio commented Oct 28, 2023

🎯 Changes

✅ Checklist

vercel bot commented Oct 28, 2023 • edited

jussisaurio commented Oct 29, 2023 • edited

juliusmarminge Nov 1, 2023

Choose a reason for hiding this comment

jussisaurio Nov 1, 2023

Choose a reason for hiding this comment

jussisaurio Nov 1, 2023

Choose a reason for hiding this comment

vercel bot commented Oct 28, 2023 •

edited

jussisaurio commented Oct 29, 2023 •

edited