Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On first time parsing an ABI #44

Closed
tjayrush opened this issue May 6, 2017 · 1 comment
Closed

On first time parsing an ABI #44

tjayrush opened this issue May 6, 2017 · 1 comment
Assignees

Comments

@tjayrush
Copy link
Member

tjayrush commented May 6, 2017

Store the parsed variable in the input data field. It's easy to generate the input data from the data itself and an ABI, it's hard to generate the parsed data because for every transaction, we have to search through all signatures. Also-- we should add counter to function and sort the function in the ABI by most frequent first thereby lessening search time.

From https://github.com/Great-Hill-Corporation/ethslurp/issues/127

@tjayrush tjayrush self-assigned this May 6, 2017
@tjayrush tjayrush added this to the Release 0.2.0 milestone Jul 25, 2017
@tjayrush
Copy link
Member Author

After running for many months without this optimization, I find it is not necessary. If performance becomes an issue this can be re-opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant