Skip to content

Commit

Permalink
fix(channels-dvr) revert permissions changes and add installation note (
Browse files Browse the repository at this point in the history
#10854)

**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->

Revert permissions changed in
#10813 and add installation
note instead.

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [x] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [x] ⚖️ My code follows the style guidelines of this project
- [x] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [x] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [x] ⬆️ I increased versions for any altered app according to semantic
versioning

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
  • Loading branch information
fenichelar authored Jul 28, 2023
1 parent d13fc27 commit 4fc5f64
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 14 deletions.
2 changes: 1 addition & 1 deletion charts/stable/channels-dvr/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ name: channels-dvr
sources:
- https://github.com/truecharts/charts/tree/master/charts/stable/channels-dvr
type: application
version: 2.1.2
version: 2.1.3
annotations:
truecharts.org/catagories: |
- media
Expand Down
11 changes: 7 additions & 4 deletions charts/stable/channels-dvr/docs/installation_notes.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,19 @@
# Channels DVR Installation Notes

:::danger Ingress
:::danger TV Everywhere Permissions

If using TV Everywhere, `runAsUser` and `runAsGroup` must both be changed to `0` and `readOnlyRootFilesystem` must be changed to `false`.

:::

## Ingress

You cannot use Ingress during the initial setup. The Channels DVR Server web interface must be accessed using the TrueNAS server IP and Channels DVR Server port (defaults to 8089).

After initial setup, ingress can be used to access the Channels DVR Server web interface.

:::

## Login

During initial setup on the Channels DVR Server web interface, you will need to login to your Channels DVR website account as described here: [https://getchannels.com/docs/channels-dvr-server/quick-guide/installation-setup/#log-in](https://getchannels.com/docs/channels-dvr-server/quick-guide/installation-setup/#log-in).

After you login on the Channels DVR website, you will be redirected back to your local Channels DVR Server web interface. However, the redirect will use the internal Kubernetes IP in the URL so it will not work. Simply change the IP in the URL to the IP of you TrueNAS server leaving the path and query parameters unmodified.

6 changes: 3 additions & 3 deletions charts/stable/channels-dvr/questions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ questions:
- value: image
description: Channels DVR
- value: tveImage
description: Channels DVR with TV Everywhere
description: Channels DVR with TV Everywhere (see installation notes)

# Include{containerBasic}
# Include{containerAdvanced}
Expand Down Expand Up @@ -83,13 +83,13 @@ questions:
description: "The UserID of the user running the application"
schema:
type: int
default: 0
default: 568
- variable: runAsGroup
label: "runAsGroup"
description: "The groupID this App of the user running the application"
schema:
type: int
default: 0
default: 568
# Include{securityContextContainer}
# Include{securityContextAdvanced}
# Include{securityContextPod}
Expand Down
6 changes: 0 additions & 6 deletions charts/stable/channels-dvr/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,6 @@ tveImage:
pullPolicy: Always
tag: latest@sha256:7e0130ad244e07f3714edadecdcc8711d9d3c11eac8409705b5c6aa8e108ca7e

securityContext:
container:
readOnlyRootFilesystem: false
runAsUser: 0
runAsGroup: 0

service:
main:
ports:
Expand Down

0 comments on commit 4fc5f64

Please sign in to comment.