Skip to content

Commit

Permalink
feat(minecraft-java) add wider packwiz support (#17523)
Browse files Browse the repository at this point in the history
**Description**

Updated minecraft-java's questions.yaml to allow downloading packwiz
packs when modloaders other than Fabric are chosen. The developer of the
docker image has
[stated](itzg/docker-minecraft-server#1238 (comment))
that packwiz support is not limited to Fabric. Mod loaders supported by
packwiz itself are listed
[here](https://packwiz.infra.link/reference/commands/packwiz/init/#options).

**⚙️ Type of change**

- [x] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**

I don't have the capability to test this at this time.

**📃 Notes:**

I haven't worked on TrueNAS apps/questions.yaml before but based on my
understanding from reading the docs this should be correct. If there is
a way to combine all the added lines using a compound show-if statement
(ie show-if type is forge or fabric or quilt or neoforge) I couldn't
find documentation on it.

**✔️ Checklist:**

- [x] ⚖️ My code follows the style guidelines of this project
- [ ] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [ ] ⬆️ I increased versions for any altered app according to semantic
versioning

---------

Signed-off-by: H <37481947+H-QueerCoded@users.noreply.github.com>
  • Loading branch information
H-QueerCoded authored Jan 27, 2024
1 parent 64a3424 commit f65459a
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion charts/stable/minecraft-java/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ sources:
- https://hub.docker.com/r/itzg/minecraft-server
- https://hub.docker.com/r/itzg/mc-backup
type: application
version: 7.1.11
version: 7.1.12
12 changes: 6 additions & 6 deletions charts/stable/minecraft-java/questions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,12 @@ questions:
description: Pufferfish
- value: CUSTOM
description: Custom
- variable: PACKWIZ_URL
label: Packwiz URL
schema:
type: string
default: ""
show_if: [[TYPE, "!=", "VANILLA"]]
- variable: CUSTOM_SERVER
label: Custom Server
description: URL or a container path to an existing JAR file, will ONLY download once.
Expand Down Expand Up @@ -208,12 +214,6 @@ questions:
type: string
default: ""
show_if: [[TYPE, "=", "FABRIC"]]
- variable: PACKWIZ_URL
label: Packwiz URL
schema:
type: string
default: ""
show_if: [[TYPE, "=", "FABRIC"]]
- variable: SPIGOT_DOWNLOAD_URL
label: Spigot Download URL
schema:
Expand Down
2 changes: 1 addition & 1 deletion charts/stable/minecraft-java/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ workload:
ONLINE_MODE: true
MEMORY: 2048M
RCON_PASSWORD: "secretrconpass"
# PACKWIZ_URL: ""
# CUSTOM_SERVER: ""
# QUILT_LOADER_VERSION: ""
# QUILT_LAUNCHER: ""
Expand All @@ -174,7 +175,6 @@ workload:
# BUKKIT_DOWNLOAD_URL: ""
# PAPERBUILD: ""
# PAPER_DOWNLOAD_URL: ""
# PACKWIZ_URL: ""
# AIRPLANE_BUILD: "lastSuccessfulBuild"
# MAGMA_CHANNEL: "stable"
# MOHIST_BUILD: ""
Expand Down

0 comments on commit f65459a

Please sign in to comment.