Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ispy-agent-dvr): Add persistence for ffmpeg6 and fix scale q's #19149

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

StevenMcElligott
Copy link
Collaborator

@StevenMcElligott StevenMcElligott commented Mar 11, 2024

Description

Added the ffmpeg6 folder to be persisted and other minor fixes

For those who didn't persist ffmpeg6 previously

Go into shell and do

cd agent
./setup-ffmpeg-linux.sh ffmpeg6/

⚒️ Fixes #17970

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@PrivatePuffin PrivatePuffin merged commit 2c3cd54 into truecharts:master Mar 11, 2024
15 checks passed
@StevenMcElligott StevenMcElligott deleted the ipsy-dvr branch March 14, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ispy-agent-dvr stuck on Installing FFmpeg 6
2 participants