Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to new ix_values system #233

Merged
merged 2 commits into from
Mar 6, 2021
Merged

Move to new ix_values system #233

merged 2 commits into from
Mar 6, 2021

Conversation

Ornias1993
Copy link
Member

@Ornias1993 Ornias1993 commented Mar 6, 2021

Description

IX Official changed the way they handled values, the new system has 3 values files:

  • test_values.yaml (the values.yaml run during tests, because tests can't use IX specific questions.yaml related settings)
  • ix_values.yaml (gets added on top of questions.yaml, without much validation. Can be used for images and tags for example)
  • default_values.yaml (optional place to highlight the default config in questions.yaml, a bit redundant imho)

It also includes the following other changes:

  • Add tests for hostNetwork
  • add hostNetwork option to all charts
  • Link dnsPolicy with hostNetwork setting
  • Create standardised groups for questions.yaml
  • Add unlimited user-defined storage to all charts (should cover your handbreak chart @stavros-k )

Fixes: #164
Fixes: #217
Fixes: #234

Type of change

  • Feature/App addition
  • Bugfix
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor of current code

How Has This Been Tested?

Manually and automatically

Notes:

Possible breaking changes:
Env vars are NOT allowed to be in the values.yaml or ix_values.yaml (they wheren't before either) so are removed. If charts break, thats for their respective maintainers to fix.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to this description that prove my fix is effective or that my feature works

@Ornias1993 Ornias1993 added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 6, 2021
@Ornias1993 Ornias1993 self-assigned this Mar 6, 2021
@Ornias1993
Copy link
Member Author

TODO:

  • Go over the documentation and append where needed

@stavros-k
Copy link
Member

There is some huge updates going on these days! (yay!!) I'll let some days to pass so most major changes are merged and then test my 2 charts and start making more!

@Ornias1993
Copy link
Member Author

Ornias1993 commented Mar 6, 2021

@stavros-k Awesome, this should be the last big change for now thats relevant for building charts.

As:

  • I'm not sure if (and when) i'm going to rework the "ports" section (I might never)
  • The Portal rework is relatively minor impact as you're ignoring the portal section already
  • The rest of the planned work is "under the hood" of other charts, the common chart or CI :)

Be aware:
This is merging into staging, not master.
Staging is a branch that is not compatible with 21.02ALPHA and will be merged as soon as 21.04 launches. Consider everything merged into staging to be "merged".

@Ornias1993 Ornias1993 merged commit 3421b01 into staging Mar 6, 2021
@Ornias1993 Ornias1993 mentioned this pull request Mar 6, 2021
10 tasks
@Ornias1993 Ornias1993 deleted the values-change branch March 8, 2021 20:38
Ornias1993 added a commit that referenced this pull request Mar 12, 2021
* Refactor questions.yaml, ix_values.yaml and values.yaml

* Add Docs
Ornias1993 added a commit that referenced this pull request Mar 17, 2021
* Refactor questions.yaml, ix_values.yaml and values.yaml

* Add Docs
Ornias1993 added a commit that referenced this pull request Mar 31, 2021
* Refactor questions.yaml, ix_values.yaml and values.yaml

* Add Docs
Ornias1993 added a commit that referenced this pull request Mar 31, 2021
* Refactor questions.yaml, ix_values.yaml and values.yaml

* Add Docs
ellienieuwdorp pushed a commit to ellienieuwdorp/charts that referenced this pull request Apr 10, 2021
* Refactor questions.yaml, ix_values.yaml and values.yaml

* Add Docs
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants