Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clusterissuer): fix var scope #22216

Merged
merged 2 commits into from
May 18, 2024
Merged

fix(clusterissuer): fix var scope #22216

merged 2 commits into from
May 18, 2024

Conversation

stavros-k
Copy link
Collaborator

Description

⚒️ Fixes #

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning
  • I made sure the title starts with feat(chart-name):, fix(chart-name): or chore(chart-name):

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@stavros-k
Copy link
Collaborator Author

@Phreeman33 saw you made a fork, probably to fix this.
feel free to copy the changes

Copy link

📝 Linting results:

✔️ Linting [charts/premium/clusterissuer]: Passed - Took 1 seconds
Total Charts Linted: 1
Total Charts Passed: 1
Total Charts Failed: 0

✅ Linting: Passed - Took 1 seconds

@Phreeman33
Copy link

@Phreeman33 saw you made a fork, probably to fix this. feel free to copy the changes
@stavros-k Thanks! Tested earlier, these changes worked fine.

@stavros-k stavros-k merged commit 5a92ff9 into master May 18, 2024
15 checks passed
@stavros-k stavros-k deleted the clusterissuer-scope branch May 18, 2024 23:05
@stavros-k
Copy link
Collaborator Author

@all-contributors please add @Phreeman33 for code

@stavros-k
Copy link
Collaborator Author

@all-contributors please add @Phreeman33 for bug

Copy link
Contributor

@stavros-k

I've put up a pull request to add @Phreeman33! 🎉

stavros-k pushed a commit that referenced this pull request May 18, 2024
Adds @Phreeman33 as a contributor for bug.

This was requested by stavros-k [in this
comment](#22216 (comment))

[skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Copy link
Contributor

@stavros-k

I've put up a pull request to add @Phreeman33! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants