Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Test refactor: enable-constantinople-hardfork.js #359

Merged

Conversation

ccowell
Copy link
Contributor

@ccowell ccowell commented Mar 5, 2019

No description provided.

Copy link
Member

@davidmurdoch davidmurdoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the npm-shrinkwrap.json- from the commit (git checkout origin/develop npm-shrinkwrap.json` then commit & push)? Also, one change requested in a comment.

it("should fail execution", async function() {
const { instance } = context;

assert.rejects(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

await this

shrinkwrap update
@davidmurdoch davidmurdoch merged commit e272001 into develop Mar 8, 2019
@davidmurdoch davidmurdoch deleted the test-refactor-enable-constantinople-hardfork-js-2 branch April 9, 2019 19:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants