Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

fix interactive documentation examples for personal namespace #863

Closed
eshaben opened this issue Mar 12, 2021 · 1 comment
Closed

fix interactive documentation examples for personal namespace #863

eshaben opened this issue Mar 12, 2021 · 1 comment
Assignees
Milestone

Comments

@eshaben
Copy link
Contributor

eshaben commented Mar 12, 2021

The following problems exist within the personal namespace of the interactive docs:

  • personal_newAccount example isn't working
  • personal_unlockAccount example doesn't work because it relies on personal_newAccount
  • personal_sendTransaction example doesn't work because it relies on personal_newAccount

The problem is due to the crypto-browserify package not being completely compatible with nodes crypto module. In personal_newAccount, encrypt is called and then we begin to run into errors with scrypt.

Could try setting up our own provider (like ganache.provider) and passing in own accounts. Or could try to polyfill the functions we need from the crypto package. Maybe try installing an scrypt browser-capable version, or using subtle crypto to .encrypt and .decrypt which uses the right aes type and so we could probably make it work somehow.

References:

@davidmurdoch
Copy link
Member

@MicaiahReid do you remember if this one is complete? If so, can you close?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants