Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Specificity order for strings and bools in Encoder should swap when strictBooleans is enabled #6028

Closed
haltman-at opened this issue May 9, 2023 · 1 comment

Comments

@haltman-at
Copy link
Contributor

Right now, strings are more specific than bools. If strictBooleans is on, this makes no sense; bools should be more specific. This is relevant because it could pose problems for overload resolution in Truffle Call, e.g. (Imagine if you wrote call C f true and got f(string) when you wanted f(bool)!)

Note that Encoder can't have specificity of types depend on the particular input, but there's no reason it can't have it depend on a flag like this. It should.

Environment

  • Truffle version (truffle version): 5.8.4
@haltman-at
Copy link
Contributor Author

Released in 5.9.4!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants