Uncaught TypeError: Cannot read properties of undefined (reading 'extra')

[cliffrowley]

I just loaded up on a different browser to test some things with another node (tried Chrome and Brave), and I'm getting a client side error. Not sure why I'm not getting it in my usual browser (Safari), though. I haven't used ComfyUI in either of those browsers previously, so I'm not sure if that makes a difference.

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'extra')
    at Object.error_flag [as pre] (nodes.js:120:17)
    at obj.<computed> [as loadGraphData] (nodes.js:52:16)
    at HTMLButtonElement.onclick (ui.js:789:17)

Turns out it's being thrown here:

ComfyUI-0246/web/js/nodes.js

Line 120 in 6d40ba2

if (!workflow.extra["0246.VERSION"]) {

[cliffrowley]

Just did a little extra testing, by disabling the node, restarting ComfyUI, then refreshing one of the browsers so it loads the default workflow, then re-enabling the node and restarting ComfyUI and yes, it does appear that this error only occurs if no workflow has been loaded previously (which also explains why I didn't see the error in Safari). As expected, the error still occurs in the browser that I didn't refresh while the node was disabled.

[Trung0246]

Huh weird, the workflow should have that key by default when being exported. I guess sometimes comfyui did not do it sometimes. Also yeah I guess I forgot to handle the null workflow.

[Trung0246]

Anyways quick fixed.