Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROV-N serialization of wasInfluenced by includes an unnecessary "-" #3

Closed
nicholsn opened this issue Apr 4, 2013 · 2 comments
Closed

Comments

@nicholsn
Copy link

nicholsn commented Apr 4, 2013

In the example below the PROV-N serialization of the wasInfluencedBy relation includes a "-".

In [1]: import prov.model as prov
In [2]: g = prov.ProvBundle()
In [3]: g.entity("e1")
Out[3]: <prov.model.ProvEntity at 0x101f2d550>
In [4]: g.entity("e2")
Out[4]: <prov.model.ProvEntity at 0x101f2d810>
In [5]: g.wasInfluencedBy("e1","e2")
Out[5]: <prov.model.ProvInfluence at 0x101f2d9d0>
In [6]: print g
document

  entity(e1)
  entity(e2)
  wasInfluencedBy(e1, e2, -)
endDocument

Based on the PROV-DM examples for this relation at http://www.w3.org/TR/prov-dm/#dfn-wasinfluencedby, it appears that this "-" is unnecessary.

The issue arrises when using the ProvToolbox to convert this PROV-N to RDF.

PROVCONVERT code says:
TestPreProcessSHORT_FilledInJobRECURSIVE.provn line 256:54 mismatched input '-' expecting OPEN_SQUARE_BRACE

If I go through the PROVN file and remove the ,- (comma-dashes) then there is no problem. The same dashes are there for the "USED" function but the PROVCONVERT program has no problem with them.

Is this a bug in the PROV Python library or ProvToolbox?

@trungdong
Copy link
Owner

Hi @nicholsn,

Thank you for spotting out the bug. There used to be an optional 'activity' attribute in Influence expressions, but this is no longer the case. I've just pushed a commit that fixes this.

@nicholsn
Copy link
Author

great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants