Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure apps with alternative bin names are handled properly #47

Closed
thedodd opened this issue Sep 16, 2020 · 2 comments
Closed

Ensure apps with alternative bin names are handled properly #47

thedodd opened this issue Sep 16, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@thedodd
Copy link
Member

thedodd commented Sep 16, 2020

Per the discussion over here #46 (comment), it would seem that Trunk needs to do a better job at determining the name of the output WASM. Let's leverage cargo-metadata as much as possible to handle edge cases like this.

This should be a simple matter of checking the package's targets (already provided by cargo-metadata), and then checking to ensure that there is only 1 bin. In the future, as we move to complete #46, we will support multiple bins, where one is the app, and others are workers.

@thedodd thedodd added the bug Something isn't working label Sep 16, 2020
@thedodd thedodd added this to the 0.5.0 | TBD milestone Sep 16, 2020
@thedodd
Copy link
Member Author

thedodd commented Sep 23, 2020

This is pretty closely related to #58, let's knock these both out together.

@thedodd
Copy link
Member Author

thedodd commented Sep 24, 2020

Ultimately, we will need to take a more robust approach with this. We will need to implement the pattern described in #46 (comment) in order to fully resolve this issue.

#58 will implement a quick fix for other naming issues. #46 will add the more robust controls and will probably ship in 0.6.0 or so.

@thedodd thedodd closed this as completed Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant