Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure rel="trunk-dist" will copy over directories #50

Closed
thedodd opened this issue Sep 21, 2020 · 0 comments · Fixed by #73
Closed

Ensure rel="trunk-dist" will copy over directories #50

thedodd opened this issue Sep 21, 2020 · 0 comments · Fixed by #73
Labels
assets Build pipelines for specific asset types cli Trunk CLI application enhancement New feature or request good first issue Good for newcomers ready Ready to be implemented
Milestone
0.7.x | TBD

Comments

@thedodd
Copy link
Member

thedodd commented Sep 21, 2020

Right now, it expects the target to be a file. If it is a dir, we should recursively copy it.
@thedodd thedodd added enhancement New feature or request good first issue Good for newcomers cli Trunk CLI application assets Build pipelines for specific asset types labels Sep 21, 2020
@thedodd thedodd added the ready Ready to be implemented label Oct 2, 2020
thedodd added a commit that referenced this issue Oct 6, 2020
@thedodd
Major refactor of pipeline system to support next wave of features.
7701795 
All assets which are to be processed by trunk must now be declared as
HTML `link` elements as such:
`<link data-trunk rel="rust|sass|..." data-attr0 data-attr1/>`.
The links may appear anywhere in the HTML and Trunk will process them and
replace them or delete them based on the associated pipeline's output.
If the link element does not have the `data-trunk` attribute, it will not
be processed.

The `--manifest-path` flag has been removed in favor of the new link
style: `<link rel="rust" href="path/to/Cargo.toml"/>`. This is optional,
and will default to the Cargo.toml of the source HTML's parent dir if
not specified.

closes #50
@thedodd thedodd mentioned this issue Oct 6, 2020
Merged
4 tasks
thedodd added a commit that referenced this issue Oct 6, 2020
@thedodd
Major refactor of pipeline system to support next wave of features.
c96541d 
All assets which are to be processed by trunk must now be declared as
HTML `link` elements as such:
`<link data-trunk rel="rust|sass|..." data-attr0 data-attr1/>`.
The links may appear anywhere in the HTML and Trunk will process them and
replace them or delete them based on the associated pipeline's output.
If the link element does not have the `data-trunk` attribute, it will not
be processed.

The `--manifest-path` flag has been removed in favor of the new link
style: `<link rel="rust" href="path/to/Cargo.toml"/>`. This is optional,
and will default to the Cargo.toml of the source HTML's parent dir if
not specified.

Update README describing new asset pipeline declaration pattern.

closes #50
thedodd added a commit that referenced this issue Oct 6, 2020
@thedodd
Major refactor of pipeline system to support next wave of features.
3e1d0c8 
All assets which are to be processed by trunk must now be declared as
HTML `link` elements as such:
`<link data-trunk rel="rust|sass|..." data-attr0 data-attr1/>`.
The links may appear anywhere in the HTML and Trunk will process them and
replace them or delete them based on the associated pipeline's output.
If the link element does not have the `data-trunk` attribute, it will not
be processed.

The `--manifest-path` flag has been removed in favor of the new link
style: `<link rel="rust" href="path/to/Cargo.toml"/>`. This is optional,
and will default to the Cargo.toml of the source HTML's parent dir if
not specified.

Update README describing new asset pipeline declaration pattern.

closes #50
thedodd added a commit that referenced this issue Oct 6, 2020
@thedodd
Major refactor of pipeline system to support next wave of features.
910bdaf 
All assets which are to be processed by trunk must now be declared as
HTML `link` elements as such:
`<link data-trunk rel="rust|sass|..." data-attr0 data-attr1/>`.
The links may appear anywhere in the HTML and Trunk will process them and
replace them or delete them based on the associated pipeline's output.
If the link element does not have the `data-trunk` attribute, it will not
be processed.

The `--manifest-path` flag has been removed in favor of the new link
style: `<link rel="rust" href="path/to/Cargo.toml"/>`. This is optional,
and will default to the Cargo.toml of the source HTML's parent dir if
not specified.

Update README describing new asset pipeline declaration pattern.

closes #50
thedodd added a commit that referenced this issue Oct 6, 2020
@thedodd
Major refactor of pipeline system to support next wave of features.
833f214 
All assets which are to be processed by trunk must now be declared as
HTML `link` elements as such:
`<link data-trunk rel="rust|sass|..." data-attr0 data-attr1/>`.
The links may appear anywhere in the HTML and Trunk will process them and
replace them or delete them based on the associated pipeline's output.
If the link element does not have the `data-trunk` attribute, it will not
be processed.

The `--manifest-path` flag has been removed in favor of the new link
style: `<link rel="rust" href="path/to/Cargo.toml"/>`. This is optional,
and will default to the Cargo.toml of the source HTML's parent dir if
not specified.

Update README describing new asset pipeline declaration pattern.

closes #50
thedodd added a commit that referenced this issue Oct 6, 2020
@thedodd
Major refactor of pipeline system to support next wave of features.
804c390 
All assets which are to be processed by trunk must now be declared as
HTML `link` elements as such:
`<link data-trunk rel="rust|sass|..." data-attr0 data-attr1/>`.
The links may appear anywhere in the HTML and Trunk will process them and
replace them or delete them based on the associated pipeline's output.
If the link element does not have the `data-trunk` attribute, it will not
be processed.

The `--manifest-path` flag has been removed in favor of the new link
style: `<link rel="rust" href="path/to/Cargo.toml"/>`. This is optional,
and will default to the Cargo.toml of the source HTML's parent dir if
not specified.

Update README describing new asset pipeline declaration pattern.

closes #50
thedodd added a commit that referenced this issue Oct 6, 2020
@thedodd
Major refactor of pipeline system to support next wave of features.
e6c23e1 
All assets which are to be processed by trunk must now be declared as
HTML `link` elements as such:
`<link data-trunk rel="rust|sass|..." data-attr0 data-attr1/>`.
The links may appear anywhere in the HTML and Trunk will process them and
replace them or delete them based on the associated pipeline's output.
If the link element does not have the `data-trunk` attribute, it will not
be processed.

The `--manifest-path` flag has been removed in favor of the new link
style: `<link rel="rust" href="path/to/Cargo.toml"/>`. This is optional,
and will default to the Cargo.toml of the source HTML's parent dir if
not specified.

Update README describing new asset pipeline declaration pattern.

closes #50
thedodd added a commit that referenced this issue Oct 8, 2020
@thedodd
Major refactor of pipeline system to support next wave of features.
109c934 
All assets which are to be processed by trunk must now be declared as
HTML `link` elements as such:
`<link data-trunk rel="rust|sass|..." data-attr0 data-attr1/>`.
The links may appear anywhere in the HTML and Trunk will process them and
replace them or delete them based on the associated pipeline's output.
If the link element does not have the `data-trunk` attribute, it will not
be processed.

The `--manifest-path` flag has been removed in favor of the new link
style: `<link rel="rust" href="path/to/Cargo.toml"/>`. This is optional,
and will default to the Cargo.toml of the source HTML's parent dir if
not specified.

Update README describing new asset pipeline declaration pattern.

closes #50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assets Build pipelines for specific asset types cli Trunk CLI application enhancement New feature or request good first issue Good for newcomers ready Ready to be implemented
Projects
None yet
Milestone
0.7.x | TBD
Development

Successfully merging a pull request may close this issue.

Major refactor of pipeline system to support next wave of features. trunk-rs/trunk
1 participant
@thedodd