Major refactor of pipeline system to support next wave of features. #73
Conversation
thedodd
force-pushed
the
hacking-on-0.7.0
branch
2 times, most recently
from
683f910
to
7701795
Compare
thedodd
changed the title
thedodd
force-pushed
the
hacking-on-0.7.0
branch
4 times, most recently
from
910bdaf
to
833f214
Compare
|
@siku2 && @MartinKavik I'm very interested to see what you both think about where this has landed. This will make adding new asset types sane, predictable and easily extensible. The main thing which I think you both might be interested in is the rendered README file. The main thing which needs review/feedback here is the pattern which I've landed on for declaring assets (which is mostly discussed in the assets section of the README). The TL;DR, especially as it relates to the web worker discussion which we had going over in #46, here is how we will accomplish this using the new pattern (which everything has been updated to use this pattern now): <head>
<link
data-trunk
rel="rust-worker"
href="path/to/Cargo.toml"
data-bin="web-worker"
data-arg0="0"
data-arg1="1"
/>
</head>A standard HTML |
thedodd
force-pushed
the
hacking-on-0.7.0
branch
from
833f214
to
804c390
Compare
thedodd
force-pushed
the
hacking-on-0.7.0
branch
from
804c390
to
e6c23e1
Compare
|
For anyone interested/watching, I am currently using a release build of this PR for development on a private app. I'll be merging this into master soon. |
All assets which are to be processed by trunk must now be declared as HTML `link` elements as such: `<link data-trunk rel="rust|sass|..." data-attr0 data-attr1/>`. The links may appear anywhere in the HTML and Trunk will process them and replace them or delete them based on the associated pipeline's output. If the link element does not have the `data-trunk` attribute, it will not be processed. The `--manifest-path` flag has been removed in favor of the new link style: `<link rel="rust" href="path/to/Cargo.toml"/>`. This is optional, and will default to the Cargo.toml of the source HTML's parent dir if not specified. Update README describing new asset pipeline declaration pattern. closes #50
thedodd
force-pushed
the
hacking-on-0.7.0
branch
from
e6c23e1
to
109c934
Compare
All assets which are to be processed by trunk must now be declared as
HTML
linkelements as such:<link data-trunk rel="rust|sass|..." data-attr0 data-attr1/>.The links may appear anywhere in the HTML and Trunk will process them and
replace them or delete them based on the associated pipeline's output.
If the link element does not have the
data-trunkattribute, it will notbe processed.
The
--manifest-pathflag has been removed in favor of the new linkstyle:
<link data-trunk rel="rust" href="path/to/Cargo.toml"/>. This is optional,and will default to the Cargo.toml of the source HTML's parent dir if
not specified.
Update README describing new asset pipeline declaration pattern.
closes #50
closes #72
todo
head, then it should be replaced there, if declared in thebodythen it should be replaced there.data-trunklinks are processed, their HTML will be replaced based on where they exist in the DOM. So if links need to appear in the HTML body for including the WASM/JS, adding thedata-trunklink to the HTML body will solve that problem.rust-workerasset type. Thehrefattr should behave exactly as it does for therustasset type.for anyone willing to review
Please take a look at the rendered README file. The main thing which needs review/feedback here is the pattern which I've landed on for declaring assets (which is mostly discussed in the assets section of the README).