Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Dropdown now called Select #2308

Closed
werdnanoslen opened this issue Mar 23, 2023 · 1 comment · Fixed by #2415
Closed

[fix] Dropdown now called Select #2308

werdnanoslen opened this issue Mar 23, 2023 · 1 comment · Fixed by #2415
Assignees
Labels
type: bug Something isn't working like it's supposed to

Comments

@werdnanoslen
Copy link
Contributor

ReactUSWDS Version & USWDS Version:

Not sure as of when, but currently on 3.4.1, the component managing the basic <select> elemet is called "Select" in all documentation, not "Dropdown. Also, the USWDS site link on storybook should now be https://designsystem.digital.gov/components/select/ (not /dropdown/)

Expected behavior

  1. Change component name to Select
  2. Change storybook to use "Select" in its title/subtitle
  3. Change USWDS link

Screenshots

image

@werdnanoslen werdnanoslen added the type: bug Something isn't working like it's supposed to label Mar 23, 2023
@haworku
Copy link
Contributor

haworku commented Mar 29, 2023

Thanks for pointing this out.

Surfacing also that renaming a component would be a breaking change. It requires all consumers to rename their components. We may want to create the new Select component, add to storybook, but still allow use of Dropdown for a period of time and marking as deprecated for the first pass of this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working like it's supposed to
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants