Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sass modules bug #2555

Merged
merged 6 commits into from
Sep 29, 2023
Merged

fix: Sass modules bug #2555

merged 6 commits into from
Sep 29, 2023

Conversation

kleinschmidtj
Copy link
Contributor

@kleinschmidtj kleinschmidtj commented Aug 10, 2023

Summary

Adds required USWDS paths for webpack in both main app config and storybook config to support USWDS tokens and theme variables inside Sass modules.

Related Issues or PRs

Closes #2554

How To Test

  1. Add a *.module.scss file for a component
  2. Import the styles into the component
  3. Use the USWDS syntax for forwarding the theme tokens and utilities
  4. See results of styles in storybook

Screenshots (optional)

@kleinschmidtj kleinschmidtj changed the title [fix] Fix sass modules bug fix: Sass modules bug Aug 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2023

Warnings
⚠️ This PR does not include changes to tests, even though it affects source code.
⚠️ This PR does not include changes to storybook, even though it affects component code.

Generated by 🚫 dangerJS against 0280777

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this

@kleinschmidtj kleinschmidtj requested review from a team as code owners September 29, 2023 18:58
@kleinschmidtj kleinschmidtj merged commit a1ed9f7 into main Sep 29, 2023
5 checks passed
@kleinschmidtj kleinschmidtj deleted the jfk-fix-sass-modules-2554 branch September 29, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] USWDS Sass utilities not working in modules
2 participants