fix: Updates sign in stories to fix aria-controls issue of show password button #2627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
werdnanoslen
requested review from
shkeating and
a team
and removed request for
a team
vinodkv2511
force-pushed
the
vinodkv2511-signin-2606
branch
from
9710a84
to
8016701
Compare
brandonlenz
approved these changes
Oct 17, 2023
|
Approved Happo diff. Looks like it was a fluke diff, unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provides the correct id of password text input in the show password button.
Related Issues or PRs
closed #2606
How To Test
Launch storybook and navigate to signin page in Page Templates
Click
open canvas in new tabbutton to open this story in a new tabRun automated accessibility checker of choice on the page that opens to check for ARIA syntax issues
Should not see an ARIA syntax issue (like below) related to the aria controls on the Show password link
Screenshots (optional)