[Breaking] Refactor Ethereum token transfer signing input

[optout21]

Description

BREAKING change. Change in Eth signing input message, introducing specialized messages for different transfers:
native coin, ERC20, generic smart contract, etc.
Fixes #1176 .

Breaking Change

SigningInput for ETH transfer: The amount field is now moved to sub-message named contractTransfer of type TransferContract. This is a breaking change!
Pay attention especially to JSON version, as the breaking change will not come out at compile time (signJSON()).

SigningInput for ERC20 transfer: This is a new addition; sub-message named contractErc20 of type ERC20TransferContract should be used, with members toAddress and amount. Building of the smart contract call is done by wallet-core, not the caller/app.

SigningInput for smart contract call: This is a new addition; for smart contract calls (except the special case of ERC20 above) a new sub-message named contractGeneric of type GenericContract should be used, with member payload.

See files for examples:

• src/proto/Ethereum.proto
• swift/Tests/Blockchains/EthereumTests.swift
• android/app/src/androidTest/java/com/trustwallet/core/app/blockchains/ethereum/TestEthereumTransactionSigner.kt
• tests/Ethereum/TWAnySignerTests.cpp
• tests/Ethereum/SignerTests.cpp

Testing instructions

Unit tests, esp. iOS&Android.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• Prefix PR title with [WIP] if necessary.
• Add tests to cover changes as needed.
• Update documentation as needed.
• I have read the guidelines for adding a new blockchain
• If there is a related Issue, mention it in the description (e.g. Fixes #<issue_number> ).

[codecov]

Codecov Report

Merging #1210 (2647c6d) into master (61091e0) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1210      +/-   ##
==========================================
+ Coverage   95.24%   95.27%   +0.03%     
==========================================
  Files         432      433       +1     
  Lines       12968    13034      +66     
==========================================
+ Hits        12351    12418      +67     
+ Misses        617      616       -1     

Impacted Files	Coverage Δ
src/Ethereum/Signer.cpp	99.02% <100.00%> (+0.49%)	⬆️
src/Ethereum/Transaction.cpp	100.00% <100.00%> (ø)
src/Ethereum/Transaction.h	100.00% <100.00%> (ø)
src/IoTeX/Staking.cpp	100.00% <100.00%> (ø)
src/Solana/Transaction.cpp	100.00% <100.00%> (ø)
src/Ethereum/Address.cpp	90.47% <0.00%> (+4.76%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35a6307...2647c6d. Read the comment docs.

[optout21]

@catenocrypt @vikmeup since this is already a breaking change, let's use string for amount/gas limit/price in proto level ?

I would not change, only because of type change.

[optout21]

After some considerations, I reverted Aeternity and Aion changes, because they just create more clutter, and does not add more clarity.
Reverted commit: 7d5a03b

[hewigovens]

@catenocrypt @vikmeup If we merge this, we need to update TrustSDK + iOS app at the same time, and ask 3rd party apps to update SDK as well