Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ethereum] Add amount to contract and fix data variable in case transfer #1223

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

hewigovens
Copy link
Contributor

#1210 followup

  • transfer and contract underlaying is same, separate cases allow user adding Transfer, Smart Contract Call easily on UI
  • Fix transfer case wrong data variable
  • some cleanup

@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #1223 (43f498c) into master (099bb4c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1223      +/-   ##
==========================================
- Coverage   95.29%   95.28%   -0.02%     
==========================================
  Files         433      433              
  Lines       13123    13069      -54     
==========================================
- Hits        12506    12453      -53     
+ Misses        617      616       -1     
Impacted Files Coverage Δ
src/Ethereum/Signer.cpp 99.06% <100.00%> (+0.03%) ⬆️
src/Ethereum/Transaction.h 100.00% <100.00%> (ø)
src/Bitcoin/CashAddress.cpp 82.22% <0.00%> (-2.40%) ⬇️
src/interface/TWStoredKey.cpp 91.57% <0.00%> (-1.06%) ⬇️
src/NEO/Witness.h 85.71% <0.00%> (-0.96%) ⬇️
src/NEO/Address.cpp 77.77% <0.00%> (-0.80%) ⬇️
src/NEO/ReadData.cpp 76.66% <0.00%> (-0.76%) ⬇️
src/Algorand/Address.cpp 87.09% <0.00%> (-0.41%) ⬇️
src/Stellar/Address.cpp 88.88% <0.00%> (-0.31%) ⬇️
src/Nimiq/Address.cpp 91.30% <0.00%> (-0.25%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 099bb4c...43f498c. Read the comment docs.

src/proto/Ethereum.proto Show resolved Hide resolved
@hewigovens
Copy link
Contributor Author

codecov sometimes complains decrease coverage by 0.01%.

@leoneparise
Copy link
Contributor

LGTM. Let's merge and release a new version before Christmas 🎉

@hewigovens hewigovens merged commit 8c18198 into master Dec 23, 2020
@hewigovens hewigovens deleted the xt/contract-amount branch December 23, 2020 12:15
Copy link

@nelsonjeff nelsonjeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blockchile

cornbread78 pushed a commit to cornbread78/wallet-core that referenced this pull request Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants