-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ethereum] Add amount to contract and fix data variable in case transfer #1223
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1223 +/- ##
==========================================
- Coverage 95.29% 95.28% -0.02%
==========================================
Files 433 433
Lines 13123 13069 -54
==========================================
- Hits 12506 12453 -53
+ Misses 617 616 -1
Continue to review full report at Codecov.
|
codecov sometimes complains |
LGTM. Let's merge and release a new version before Christmas 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blockchile
#1210 followup
transfer
andcontract
underlaying is same, separate cases allow user addingTransfer
,Smart Contract Call
easily on UItransfer
case wrong data variable