Generic Bech32Address class, Cosmos, Zilliqa and Binance use it. #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commit of the following:
Binance address based on Bech32Address.
Generic Bech32Address class, Cosmos and Zilliqa use it.
Codecov Report
@@ Coverage Diff @@
## master #709 +/- ##
==========================================
- Coverage 85.35% 85.32% -0.03%
==========================================
Files 297 302 +5
Lines 8297 8287 -10
==========================================
- Hits 7082 7071 -11
- Misses 1215 1216 +1
Continue to review full report at Codecov.
|
hewigovens
reviewed
Nov 4, 2019
hewigovens
reviewed
Nov 4, 2019
hewigovens
approved these changes
Nov 4, 2019
|
Should we also update |
I did along the way, they are affected only a little bit. |
optout21
changed the title
|
Ready for review |
hewigovens
reviewed
Nov 5, 2019
hewigovens
reviewed
Nov 5, 2019
vikmeup
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New generic Bech32 address class;
Cosmos, Zilliqa and Binance addresses derived from it.
Fixes #635 .
Types of changes
Checklist