Any Signer Stellar support #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikmeup
approved these changes
Dec 2, 2019
Codecov Report
@@ Coverage Diff @@
## master #749 +/- ##
==========================================
+ Coverage 86.34% 86.35% +<.01%
==========================================
Files 314 314
Lines 9720 9727 +7
==========================================
+ Hits 8393 8400 +7
Misses 1327 1327
Continue to review full report at Codecov.
|
hewigovens
approved these changes
Dec 3, 2019
EnoRage
added a commit
to EnoRage/wallet-core
that referenced
this pull request
Jan 1, 2020
* [Any::Stellar] - In progress rn * Placed valid json for stellar transaction test * fix & un-comment stellar signer sign call * [Any::Stellar] - In progress rn, add some fixes * [Any::Stellar] - In progress rn, add some fixes * [Any::Stellar] - Added successfully. * [Any::Stellar] - Added successfully. Cleanup * [Any::Stellar] - Added successfully. Cleanup #2 * [Any::Stellar] - Added successfully. Cleanup #3 * [Any::Stellar] - Added successfully. Cleanup #4 * [Any::Stellar] - Added successfully. Cleanup #5 * [Any::Stellar] - Added successfully. Cleanup #6 * [Any::Stellar] - Added successfully. Cleanup #7 * [Any::Stellar] - Added successfully. Cleanup trustwallet#8 * [Any::Stellar] - Added successfully. Cleanup trustwallet#9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Stellar to Any Signer + Test to test/Any for it
Testing instructions
Run tests
Types of changes
Add code to src/Any/Signer.cpp
Add code to tests/Any/SignerTests.cpp
Checklist
[WIP]if necessary.