Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Nano #8

Closed
13 tasks
hewigovens opened this issue Feb 17, 2019 · 7 comments · Fixed by #385
Closed
13 tasks

Add support for Nano #8

hewigovens opened this issue Feb 17, 2019 · 7 comments · Fixed by #385
Assignees

Comments

@hewigovens
Copy link
Contributor

hewigovens commented Feb 17, 2019

Name: Nano
HD Derivation Scheme: BIP44/165
Symbol: NANO

Checklist

  • Implement functionality in C++. Put it in a subfolder of src/.
    • Address (if necessary)
    • Transaction (if necessary)
    • Signer
  • Write unit tests. Put them in a subfolder of tests/.
  • Add relevant constants in TWCoinType, TWP2SHPrefix, TWEthereymChainID, TWHRP, etc., as necessary.
  • Return correct curve and purpose in src/Coin.cpp.
  • Implement address validation and derivation in src/Coin.cpp.
  • Implement coin configuration src/include/TWCoinTypeConfiguration.cpp.
  • Write interface header in include/TrustWalletCore and implement the interface in src/interface.
    • Address interface (if necessary).
    • Signing interface.
  • Validate generated code in Android an iOS projects. Write integration tests for each.
@eddywm eddywm self-assigned this Feb 19, 2019
This was referenced Feb 21, 2019
@zhyatt
Copy link

zhyatt commented Mar 3, 2019

@hewigovens @eddywm Thanks for looking into the integration of Nano into your wallet. Some of the links you have aren't updated with the latest information. For example block details in the nanode.co link above are incorrect. We'd recommend reviewing the integration guides here https://developers.nano.org/guides and if you have questions please reach out to info-at-nano.org to connect with our team.

@eddywm
Copy link
Contributor

eddywm commented Mar 3, 2019

Hey @zhyatt
https://developers.nano.org/guides seems to be lacking important information necessary for integration.
Necessary Informations are missing in that guide like :

  • Mnemonic derivation used and reference cases : Public Key <-- Private Key <-- Extended Keys <-- Phrase
  • Account / Address Derivation
  • Transaction structure and building

That's the reason why we picked old seemingly outdated guide. I we can get updated information on those listed points, that'll be well helpful

@vikmeup
Copy link
Contributor

vikmeup commented Mar 12, 2019

@eddywm can you update progress on the integration?

@eddywm
Copy link
Contributor

eddywm commented Mar 12, 2019

I'll be starting in this week.
I was waiting for the right curve to land in and to finish top priority tasks I had.

@roosmaa
Copy link
Contributor

roosmaa commented Apr 23, 2019

Nano team has asked me to pick up this integration. Plan is to have the pull-requests up for review by the end of the week.

@eddywm
Copy link
Contributor

eddywm commented Apr 23, 2019

Nano team has asked me to pick up this integration. Plan is to have the pull-requests up for review by the end of the week.

That's awesome we'll be glad to help with some guidance.

@roosmaa
Copy link
Contributor

roosmaa commented Apr 25, 2019

Ok, I have integration ready on my fork of wallet-core. Will be creating 2 pull requests (as per the integration guide), first one for the trezor-crypto changes. When that is merged, will create the 2nd PR for the actual coin integration. There are a couple of points where I'd like TW team input, which I'll raise in the respective PRs.

This was referenced Apr 25, 2019
EnoRage pushed a commit to EnoRage/wallet-core that referenced this issue Dec 2, 2019
vikmeup pushed a commit that referenced this issue Dec 3, 2019
* [Any::Stellar] - In progress rn

* Placed valid json for stellar transaction test

* fix & un-comment stellar signer sign call

* [Any::Stellar] - In progress rn, add some fixes

* [Any::Stellar] - In progress rn, add some fixes

* [Any::Stellar] - Added successfully.

* [Any::Stellar] - Added successfully. Cleanup

* [Any::Stellar] - Added successfully. Cleanup #2

* [Any::Stellar] - Added successfully. Cleanup #3

* [Any::Stellar] - Added successfully. Cleanup #4

* [Any::Stellar] - Added successfully. Cleanup #5

* [Any::Stellar] - Added successfully. Cleanup #6

* [Any::Stellar] - Added successfully. Cleanup #7

* [Any::Stellar] - Added successfully. Cleanup #8

* [Any::Stellar] - Added successfully. Cleanup #9
EnoRage added a commit to EnoRage/wallet-core that referenced this issue Jan 1, 2020
* [Any::Stellar] - In progress rn

* Placed valid json for stellar transaction test

* fix & un-comment stellar signer sign call

* [Any::Stellar] - In progress rn, add some fixes

* [Any::Stellar] - In progress rn, add some fixes

* [Any::Stellar] - Added successfully.

* [Any::Stellar] - Added successfully. Cleanup

* [Any::Stellar] - Added successfully. Cleanup #2

* [Any::Stellar] - Added successfully. Cleanup #3

* [Any::Stellar] - Added successfully. Cleanup #4

* [Any::Stellar] - Added successfully. Cleanup #5

* [Any::Stellar] - Added successfully. Cleanup #6

* [Any::Stellar] - Added successfully. Cleanup #7

* [Any::Stellar] - Added successfully. Cleanup trustwallet#8

* [Any::Stellar] - Added successfully. Cleanup trustwallet#9
DeanDonkov pushed a commit to changex-app/wallet-core that referenced this issue Apr 7, 2023
Co-authored-by: Valeri Dobrev <valeridobrev@GoStartupss-Mac-mini.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants