-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Nano #8
Comments
@hewigovens @eddywm Thanks for looking into the integration of Nano into your wallet. Some of the links you have aren't updated with the latest information. For example block details in the nanode.co link above are incorrect. We'd recommend reviewing the integration guides here https://developers.nano.org/guides and if you have questions please reach out to info-at-nano.org to connect with our team. |
Hey @zhyatt
That's the reason why we picked old seemingly outdated guide. I we can get updated information on those listed points, that'll be well helpful |
@eddywm can you update progress on the integration? |
I'll be starting in this week. |
Nano team has asked me to pick up this integration. Plan is to have the pull-requests up for review by the end of the week. |
That's awesome we'll be glad to help with some guidance. |
Ok, I have integration ready on my fork of wallet-core. Will be creating 2 pull requests (as per the integration guide), first one for the trezor-crypto changes. When that is merged, will create the 2nd PR for the actual coin integration. There are a couple of points where I'd like TW team input, which I'll raise in the respective PRs. |
* [Any::Stellar] - In progress rn * Placed valid json for stellar transaction test * fix & un-comment stellar signer sign call * [Any::Stellar] - In progress rn, add some fixes * [Any::Stellar] - In progress rn, add some fixes * [Any::Stellar] - Added successfully. * [Any::Stellar] - Added successfully. Cleanup * [Any::Stellar] - Added successfully. Cleanup #2 * [Any::Stellar] - Added successfully. Cleanup #3 * [Any::Stellar] - Added successfully. Cleanup #4 * [Any::Stellar] - Added successfully. Cleanup #5 * [Any::Stellar] - Added successfully. Cleanup #6 * [Any::Stellar] - Added successfully. Cleanup #7 * [Any::Stellar] - Added successfully. Cleanup #8 * [Any::Stellar] - Added successfully. Cleanup #9
* [Any::Stellar] - In progress rn * Placed valid json for stellar transaction test * fix & un-comment stellar signer sign call * [Any::Stellar] - In progress rn, add some fixes * [Any::Stellar] - In progress rn, add some fixes * [Any::Stellar] - Added successfully. * [Any::Stellar] - Added successfully. Cleanup * [Any::Stellar] - Added successfully. Cleanup #2 * [Any::Stellar] - Added successfully. Cleanup #3 * [Any::Stellar] - Added successfully. Cleanup #4 * [Any::Stellar] - Added successfully. Cleanup #5 * [Any::Stellar] - Added successfully. Cleanup #6 * [Any::Stellar] - Added successfully. Cleanup #7 * [Any::Stellar] - Added successfully. Cleanup trustwallet#8 * [Any::Stellar] - Added successfully. Cleanup trustwallet#9
Co-authored-by: Valeri Dobrev <valeridobrev@GoStartupss-Mac-mini.local>
Name: Nano
HD Derivation Scheme: BIP44/165
Symbol:
NANO
Checklist
src/
.tests/
.TWCoinType
,TWP2SHPrefix
,TWEthereymChainID
,TWHRP
, etc., as necessary.src/Coin.cpp
.src/Coin.cpp
.src/include/TWCoinTypeConfiguration.cpp
.include/TrustWalletCore
and implement the interface insrc/interface
.The text was updated successfully, but these errors were encountered: